Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make V0EventSelector produce skimmed V0 collections based on their mass #46005

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 14, 2024

PR description:

Title says it all, it was suggested to modify V0EventSelector in order to produce skimmed V0 collections based on their mass, to enhance the purity in terms of strange origin of the tracks analyzed via StandaloneTrackMonitor, based on the results shown here and here.
This update concerns only the Tracking Data/MC validation suite and is of no consequence on any DQM production sequence run in online or offline DQM.

PR validation:

Relies on the existing unit tests of this package: scram b runtests_testTrackingDATAMC

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, might be backported later on for convenience

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 14, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/TrackingMonitorSource (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@JanFSchulte, @VinInn, @VourMa, @arossi83, @fioriNTU, @idebruyn, @jandrea, @mmusich, @mtosi, @sroychow, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Sep 14, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-838514/41514/summary.html
COMMIT: f47b3b0
CMSSW: CMSSW_14_2_X_2024-09-13-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46005/41514/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 120 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3437830
  • DQMHistoTests: Total failures: 3888
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3433922
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 197 log files, 168 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 1 / 43 workflows

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46005 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 14, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-838514/41516/summary.html
COMMIT: 43db8e1
CMSSW: CMSSW_14_2_X_2024-09-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46005/41516/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@vicha-w
Copy link

vicha-w commented Sep 16, 2024

Hi @mmusich,

This PR has been tested on DQM playback machine with 14_0_15_patch1 and run 385627. All clients ended gracefully. For more information please refer to DQM^2 mirror logs here: https://cmsweb.cern.ch/dqm/dqm-square/?run=518657&db=playback

Please note that this PR is tested on 14_0_15_patch1 instead of the targeted 14_2_X.

Best regards,
Vichayanun

@mmusich
Copy link
Contributor Author

mmusich commented Sep 16, 2024

Hi @vicha-w

This PR has been tested on DQM playback machine with 14_0_15_patch1 and run 385627.

thanks, though this wasn't really necessary, see PR description:

This update concerns only the Tracking Data/MC validation suite and is of no consequence on any DQM production sequence run in online or offline DQM.

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c891039 into cms-sw:master Sep 16, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_V0EventSelector branch September 16, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants