-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: remove DoubleSensGeomDet (ph-2 InnerTracker) #45993
bugfix: remove DoubleSensGeomDet (ph-2 InnerTracker) #45993
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45993/41764 |
A new Pull Request was created by @emiglior for master. It involves the following packages:
@Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This way the test will be automatically forward-ported the next time we move the default geometry.
Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py
Outdated
Show resolved
Hide resolved
Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py
Outdated
Show resolved
Hide resolved
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45993/41765 |
Pull request #45993 was updated. @Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please check and sign again. |
@cmsbuild, please test |
+1 Size: This PR adds an extra 32KB to repository Comparison SummarySummary:
|
+alca |
+1 |
urgent
|
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
bugfix: this PR fixes the CMSSW issues #43097 and #45792 removing the DoubleSensGeomDet introduced for phase-2 Inner Tracker modules (T33 tracker geometry and following T35, T36, T37, T38 and T39) but actually not used in the code (and unlikely to be used in future).
No changes expected for the output.
PR validation:
Tested on:
cmsRun Fireworks/Geometry/python/dumpRecoGeometry_cfg.py tag=2026 version=D110
(up to version D113)
cmsRun Alignment/TrackerAlignment/test/Misalignments/createRandomlyMisalignedGeometry_Phase2_cfg.py
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport (there will be a companion backport for 14_1_X cycle)