Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: remove DoubleSensGeomDet (ph-2 InnerTracker) #45993

Merged

Conversation

emiglior
Copy link
Contributor

PR description:

bugfix: this PR fixes the CMSSW issues #43097 and #45792 removing the DoubleSensGeomDet introduced for phase-2 Inner Tracker modules (T33 tracker geometry and following T35, T36, T37, T38 and T39) but actually not used in the code (and unlikely to be used in future).

No changes expected for the output.

PR validation:

Tested on:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport (there will be a companion backport for 14_1_X cycle)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 12, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emiglior for master.

It involves the following packages:

  • Alignment/TrackerAlignment (alca)
  • Configuration/AlCa (alca)
  • Fireworks/Geometry (visualization)
  • Geometry/TrackerGeometryBuilder (geometry)
  • RecoTracker/MeasurementDet (reconstruction)

@Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @Martin-Grunewald, @VinInn, @VourMa, @adewit, @alja, @bsunanda, @dgulhan, @fabiocos, @felicepantaleo, @gpetruc, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tlampen, @tocheng, @venturia, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@emiglior
Copy link
Contributor Author

@alja
Copy link
Contributor

alja commented Sep 12, 2024

+1

Copy link
Contributor

@mmusich mmusich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way the test will be automatically forward-ported the next time we move the default geometry.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45993 was updated. @Dr15Jones, @alja, @bsunanda, @civanch, @cmsbuild, @consuegs, @jfernan2, @makortel, @mandrenguyen, @mdhildreth, @perrotta, @saumyaphor4252 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Sep 12, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b4ef5/41495/summary.html
COMMIT: 31684f2
CMSSW: CMSSW_14_2_X_2024-09-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45993/41495/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

+alca

@jfernan2
Copy link
Contributor

+1

@mmusich
Copy link
Contributor

mmusich commented Sep 13, 2024

urgent

@alja
Copy link
Contributor

alja commented Sep 13, 2024

+1

@civanch
Copy link
Contributor

civanch commented Sep 14, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1be2984 into cms-sw:master Sep 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants