Fix: Avoid adding HGCalUncalibRecHits to the event if digis do not exist

[felicepantaleo]

This update ensures that HGCalUncalibRecHits are not added to the event if the corresponding digi collections do not exist. Previously, the rec hits were always put into the event, even when the digi handles were invalid. The updated logic includes checks to prevent this behavior, avoiding unnecessary allocations and potential issues during event processing.
Key Changes:

• Added conditions to ensure HGCalUncalibRecHits are only added to the event if the corresponding digi collection exists.
• Removed redundant evt.put() calls for invalid digi
• Improved the clarity and structure of the HGCalUncalibRecHitProducer::produce function by handling each digi collection independently.

[cmsbuild]

cms-bot internal usage

[felicepantaleo]

type hgcal

[felicepantaleo]

type bug-fix

[felicepantaleo]

@cms-sw/hgcal-dpg-l2 fyi

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45992/41761

[cmsbuild]

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

• RecoLocalCalo/HGCalRecProducers (reconstruction, upgrade)

@jfernan2, @mandrenguyen, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@apsallid, @bsunanda, @cseez, @edjtscott, @hatakeyamak, @lecriste, @lgray, @missirol, @pfs, @rovere, @sameasy, @sethzenz, @vandreev11, @youyingli this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99af08/41487/summary.html
COMMIT: 3b0053a
CMSSW: CMSSW_14_2_X_2024-09-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45992/41487/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 176 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331135
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[srimanob]

@cmsbuild please test
Re-trigger the test after a month.

[srimanob]

Kindly ping @cms-sw/upgrade-l2

[Moanwar]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-99af08/42159/summary.html
COMMIT: 3b0053a
CMSSW: CMSSW_14_2_X_2024-10-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45992/42159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 36 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331066
• DQMHistoTests: Total failures: 3439
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327607
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1