possibility of configuring the OMTF emulator directly from XMLs (14_0_X)

[kbunkow]

PR description:

This PR adds the possibility of configuring the OMTF emulator directly from the config XML, without using the L1TMuonOverlapPhase1ParamsESProducer.

PR validation:

The PR was validated by running the L1T DQM on one file from run 385422.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of #45032
Only the files from the L1TMuonOverlapPhase1 folder are backported, as L1TMuonOverlapPhase2 is not included in the CMSSW_14_0_X.
This PR will be followed by the backport of #45984

This PR and the backport of #45984 will ensure that the OMTF emulator will be configured from the XML files corresponding to the 2024 OMTF algorithm version that was deployed at CSM on 19th March 2024, provided the Era Run3_2024 is defined for the job.
This will fix the data-emulator mismatches present in the DQM since the beginning of the 2024 pp run. Besides, will ensure the upcoming 2024 MC production will use the 2024 OMTF algorithm version.

Details of changes:

OMTFReconstruction.h and OMTFReconstruction.cc
The possibility of configuring the OMTF emulator directly from the config XML is added. When both patternsXMLFile and configXMLFile are given from the python config of the simOmtfDigis or simOmtfPhase2Digis, the L1TMuonOverlapParams are read directly from these files, and the L1TMuonOverlapPhase1ParamsESProducer is not needed. Otherwise, the L1TMuonOverlapParams are obtained from the eventSetup (so from the DB, or from the L1TMuonOverlapPhase1ParamsESProducer - if it is defined).

L1Trigger/L1TMuonOverlapPhase1/src/Omtf/OMTFProcessor.cc line
trackAddr[3] = myCand->getGpResultUnconstr().getPdfSumUnconstr(); is removed, as uGMT expects 3 entries in the TrackAddress (when there were 4, uGMT was generating a warning).

[cmsbuild]

A new Pull Request was created by @kbunkow for CMSSW_14_0_X.

It involves the following packages:

• L1Trigger/L1TMuonOverlapPhase1 (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from possibility of configuring the OMTF emulator directly from XMLs #45032

[cmsbuild]

cms-bot internal usage

[kbunkow]

@aloeliger: maybe I should add the backport of #45984 to this PR? #45984 changes only one file L1Trigger/L1TMuonOverlapPhase1/python/simOmtfDigis_cfi.py

[kbunkow]

@aloeliger: maybe I should add the backport of #45984 to this PR? The PR #45984 changes only one file L1Trigger/L1TMuonOverlapPhase1/python/simOmtfDigis_cfi.py

[aloeliger]

@kbunkow I would keep them separate.

[aloeliger]

please test

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9134/41530/summary.html
COMMIT: ff3777b
CMSSW: CMSSW_14_0_X_2024-09-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45988/41530/install.sh to create a dev area with all the needed externals and cmssw changes.

There was an issue with git-cms-merge-topic you can see the log here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9134/41530/git-merge-result

[aloeliger]

Weird error attempting to merge in the PR:

++ git ls-remote -t [email protected]:cms-sw/cmssw.git 'refs/pull/45988/head^{}'
++ cut -c -40
kex_exchange_identification: Connection closed by remote host
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
+ COMMIT=
+ '[' -z '' ']'
+ COMMIT=refs/pull/45988/head
+ git fetch -n [email protected]:cms-sw/cmssw.git +refs/pull/45988/head:cms-sw/refs/pull/45988/head
kex_exchange_identification: Connection closed by remote host
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[aloeliger]

Hopefully it's temporary?

[aloeliger]

please test

[vlimant]

urgent

[mmusich]

backport of #45032

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb9134/41531/summary.html
COMMIT: ff3777b
CMSSW: CMSSW_14_0_X_2024-09-16-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45988/41531/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 9 lines from the logs
• Reco comparison results: 57 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3346841
• DQMHistoTests: Total failures: 72
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3346749
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

• @kbunkow have you already made a backport of Added Era_Run3_2024 modifier to simOmtfDigis, to use OMTF 2024 config #45984? If not, please do so

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1