[SIM] improved initialisation

[civanch]

PR description:

This PR is an attempt to fix issue #45747 , where both Geant4 warnings/exceptions and generator exceptions are reported. This PR making instantion of the main Geant4 singletons in the fix order, so less dependent on architecture. This update does not change CPU at initialisation and does not affect run time. The main effect avoid misleading printouts if there is a problem in a WF.

PR validation:

short matrix

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

[cmsbuild]

cms-bot internal usage

[civanch]

@iarspider, @smuzaffar , please, try to test this PR at ASNEEDED_X. If G4 warnings will be gone I will add full description of this PR.

[iarspider]

@cmsbuild please test workflow 132.0,148.0,158.0,159.0 for CMSSW_14_2_ASNEEDED_X

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45986/41752

[cmsbuild]

A new Pull Request was created by @civanch for master.

It involves the following packages:

• SimG4Core/Application (simulation)

@civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos, @makortel, @martinamalberti, @rovere, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5601d/41471/summary.html
COMMIT: 9cd8cb5
CMSSW: CMSSW_14_2_ASNEEDED_X_2024-09-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45986/41471/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 4 errors in the following unit tests:

---> test test_MC_23_crosscheck had ERRORS
---> test test_MC_23_setup had ERRORS
---> test test_MC_22_setup had ERRORS
and more ...

RelVals

• 7.3

----- Begin Fatal Exception 12-Sep-2024 11:23:19 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

• 8.0

----- Begin Fatal Exception 12-Sep-2024 11:23:24 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

• 25.0

----- Begin Fatal Exception 12-Sep-2024 11:23:24 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 9.0
• 1306.0
• 1330.0
• 101.0
• 25202.0
• 312.0
• 10224.0
• 11634.0
• 12434.0
• 12834.0
• 12834.7
• 12846.0
• 13034.0
• 29634.0
• 250202.181
• 29634.75
• 29696.0
• 29700.0
• 29834.999
• 24834.911
• 29634.911
• 132.0
• 158.0
• 148.0
• 159.0

AddOn Tests

• hlt_mc_Fake

----- Begin Fatal Exception 12-Sep-2024 11:21:48 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

• hlt_mc_Fake1

----- Begin Fatal Exception 12-Sep-2024 11:21:48 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

• hlt_mc_Fake2

----- Begin Fatal Exception 12-Sep-2024 11:21:50 CEST-----------------------
An exception of category 'Geant4 fatal exception' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Calling method for module OscarMTProducer/'g4SimHits'
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_Special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45986/41755

[cmsbuild]

Pull request #45986 was updated. @civanch, @cmsbuild, @mdhildreth can you please check and sign again.

[civanch]

@cmsbuild please test workflow 132.0 for CMSSW_14_2_ASNEEDED_X

[civanch]

Now Geant4 warnings/exceptions gone, it become clear that the problem is in generators.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45986/41771

[cmsbuild]

Pull request #45986 was updated. @civanch, @cmsbuild, @mdhildreth can you please check and sign again.

[civanch]

please test

I would guess more tests in ASNEEDED not needed anymore.

[cmsbuild]

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5601d/41500/summary.html
COMMIT: 9390806
CMSSW: CMSSW_14_2_X_2024-09-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45986/41500/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331158
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3331132
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 193 log files, 163 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1