-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Alpaka Harvesting for Phase2 #45963
Conversation
type bug-fix |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45963/41715 |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
enable gpu |
please test |
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
GPU Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
urgent
|
wondering if the harvester should also be made fool-proof against missing input conditions (generally we do let harvesting run even upon missing inputs) @cms-sw/trk-dpg-l2 . |
@cms-sw/dqm-l2 gentle ping |
hi @AdrianoDee , we observe some small differences in the bin-by-bin GPU comparison for the WF 29834.403, eg. in the number of tracks, see for instance https://tinyurl.com/28wcaf43 , is this expected? |
Hi @antoniovagnerini thanks for the feedback. Yes, these are ascribable to the "usual" fluctuations we'd expect for this kind of GPU workflows. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
In the latest IBs we have a couple of failures for Phase2
*.403
wfs due to the fact that the heterogenous harvesting step tries to run the RAW data harvester (serial and device). This PR proposes a small change to fix that.PR validation:
runTheMatrix.py -w upgrade -l 29634.403
runs