Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Tier0Handler: add maxTime, improve cert warning #45945

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

JanChyczynski
Copy link
Contributor

@JanChyczynski JanChyczynski commented Sep 6, 2024

PR description:

Before this PR Tier0Handler was running a curl command using only the --connect-timeout flag which sets the timeout for connecting. If the connection is established but the server takes forever to respond, the command waits indefinitely. To avoid hung-up processes maxTime argument was added to Tier0Handler setting the --max-time flag. This flag sets the maximum time for the whole curl command.

Tier0Handler is used in the conddb command and the maxTime was set to 60 s, the connection timeout was left at 1 s.

Also, extends the warning information when the certificates are not provided with information about the X509_USER_CERT and X509_USER_KEY env variables.

This is a follow-up to #45779

PR validation:

Tested by running python3 tier0.py which is running the test for it and by running conddb showFSCR (for the latter scram b is needed beforehand).

The proper functionality of --connect-timeout and --max-time in Tier0Handler was tested by changing the T0 API URL using the TIER0_API_URL env variable to:

  • http://localhost:8099/ and running nc -kl 8099 to test being able to connect but never receiving a response
  • https://example.com:81/ to test the connection timeout

Backport

Backport of #45943 to 14_0_X

FYI @perrotta @francescobrivio @PonIlya

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

A new Pull Request was created by @JanChyczynski for CMSSW_14_0_X.

It involves the following packages:

  • CondCore/Utilities (db)

@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @mmusich, @rsreds, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor

perrotta commented Sep 6, 2024

backport of #45943

@perrotta
Copy link
Contributor

perrotta commented Sep 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0a7d91/41394/summary.html
COMMIT: e218318
CMSSW: CMSSW_14_0_X_2024-09-08-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45945/41394/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3346637
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346608
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Sep 9, 2024

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 05fc563 into cms-sw:CMSSW_14_0_X Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants