-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_1_X] Tier0Handler: add maxTime, improve cert warning #45944
[14_1_X] Tier0Handler: add maxTime, improve cert warning #45944
Conversation
A new Pull Request was created by @JanChyczynski for CMSSW_14_1_X. It involves the following packages:
@cmsbuild, @consuegs, @francescobrivio, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
cms-bot internal usage |
backport of #45943 |
please test
|
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+db |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Before this PR Tier0Handler was running a
curl
command using only the--connect-timeout
flag which sets the timeout for connecting. If the connection is established but the server takes forever to respond, the command waits indefinitely. To avoid hung-up processes maxTime argument was added toTier0Handler
setting the--max-time
flag. This flag sets the maximum time for the wholecurl
command.Tier0Handler
is used in theconddb
command and the maxTime was set to 60 s, the connection timeout was left at 1 s.Also, extends the warning information when the certificates are not provided with information about the
X509_USER_CERT
andX509_USER_KEY
env variables.This is a follow-up to #45779
PR validation:
Tested by running
python3 tier0.py
which is running the test for it and by runningconddb showFSCR
(for the latterscram b
is needed beforehand).The proper functionality of
--connect-timeout
and--max-time
inTier0Handler
was tested by changing the T0 API URL using theTIER0_API_URL
env variable to:http://localhost:8099/
and runningnc -kl 8099
to test being able to connect but never receiving a responsehttps://example.com:81/
to test the connection timeoutBackport
Backport of #45943 to 14_1_X
FYI @perrotta @francescobrivio @PonIlya