Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 #45939

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 6, 2024

PR description:

Development of HLT menu for CMSSW_12_4_HLT_X.
This update is meant exclusively for the Summer2024 production of Run 3 MC.

This PR is NOT a backport.

This version of the GRun Frozen HLT menu corresponds to to the "V1.5" menu for the 2022 pp data-taking period. The older version "V1.4" is removed. All TSG integration tests are updated accordingly.
This update includes the integration of the following JIRA tickets:

  • CMSHLT-2474: [TSG] fixes to PS values of 5 triggers (e.g. HLT_ZeroBias_Alignment_v*)
  • CMSHLT-2486: [BPH] new triggers with dz requirement for double-electron parking
  • CMSHLT-2487: [BPH] single-electron control trigger for double-electron parking triggers (currectly disabled, PS=0)
  • CMSHLT-2488: [BPH] another single-electron control trigger for double-electron parking triggers (currectly disabled, PS=0)
  • CMSHLT-2494: [EXO] fix to inclusive delayed-jet control trigger
  • CMSHLT-2366: [BTV] disable DeepCSV triggers of GRun
  • CMSHLT-2476: [TSG] seed of HLT_EphemeralZeroBias changed to L1_ZeroBias_copy
  • CMSHLT-2478: [MUO] removed some HLT-muon modules from suppressWarning list
  • CMSHLT-2491: [TSG] update PSs of HLT_HT300_Beamspot trigger
  • CMSHLT-2495: [TSG] update PSs of Ephemeral triggers
  • CMSHLT-2497: [TSG] added L1T seed to HLT_EphemeralPhysics (L1A Physics "masking" L1_ZeroBias_copy)
  • CMSHLT-2499: [TSG] added L1_SingleTau130er2p1 to L1T seeds using L1_SingleTau120er2p1
  • CMSHLT-2501: [EXO] added L1Tau-seeded delayed-jet triggers
  • CMSHLT-2514: [TSG] disable two displaced-dijet and two PNET triggers
  • CMSHLT-2518: [HIG] update of 1 L1T seed and 2 PSs of MSSM-Hbb control triggers
  • CMSHLT-2519: [TSG] disable 4 fatjet softdrop-mass triggers plus other PS changes
  • CMSHLT-2520: [BTV] updated PSs of BTagMu triggers
  • CMSHLT-2527: [EXO] updated L1T seed of SingleLLPJet triggers
  • CMSHLT-2534: [JME] doubled PS of AlCa_*PFJet* triggers
  • CMSHLT-2537: [TSG] sync PSs of offline menu with V1.4.5 online menu
  • CMSHLT-2539: [TSG] use common PF-scouting sequence in MC_Run3_PFScoutingPixelTracking_v Path

This corresponds to the updates to the GRun subtable as in #39679 and #39926

In addition, commit 8d33e25 removes support for the frozen menu 2022 V1.2, unused for the Summer24 MC production.

PR validation:

TSG integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be forward-ported.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

A new Pull Request was created by @mmusich for CMSSW_12_4_HLT_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

@cmsbuild, please test

@mmusich mmusich changed the title HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 [12.4.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 Sep 6, 2024
@mmusich mmusich changed the title [12.4.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 [12.4.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 Sep 6, 2024
@mmusich mmusich changed the title [12.4.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 [12.4_HLT_X] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5 Sep 6, 2024
@vlimant
Copy link
Contributor

vlimant commented Sep 6, 2024

Hi @mmusich , thanks for the PR. Is it possible to keep v1.4 in, or are the changes in the v1.5 menu incompatible ?

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

Is it possible to keep v1.4

It is possible, I'd rather not, given the amount of confusion that having multiple menus has created in PdmV.

@vlimant
Copy link
Contributor

vlimant commented Sep 6, 2024

please keep v1.4 around ; never mind the confusion

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

please keep v1.4 around ; never mind the confusion

please provide a justification.

@vlimant
Copy link
Contributor

vlimant commented Sep 6, 2024

for the Summer24 MC production for 2022, we would like to keep the option of choosing between v1.4 and v1.5, even though the v1.5 option is preferred

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

for the Summer24 MC production for 2022, we would like to keep the option of choosing between v1.4 and v1.5, even though the v1.5 option is preferred

I would think this decision is ultimately a TSG one. When I get word from TSG coordination to keep V1.4 I'll comply.

@vlimant
Copy link
Contributor

vlimant commented Sep 6, 2024

agreed.
2 cents : "rather not, given the amount of confusion that having multiple menus has created in PdmV." is not a good argument to drop it. while my argument to keep it is more sensible.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

2 cents : "rather not, given the amount of confusion that having multiple menus has created in PdmV." is not a good argument to drop it.

I beg to disagree, because any mistakes in the L1T+HLT configuration would need then to be ultimately debugged by TSG experts, thus I would tend to minimize the amount of effort we need to spend on it.

@antoniovilela
Copy link
Contributor

What is missing for this PR? Does it impact validation for the production?

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

What is missing for this PR?

I am not sure to understand the question: I guess passing tests and hlt signature.

Does it impact validation for the production?

probably. PPD should clarify.

@antoniovilela
Copy link
Contributor

What is missing for this PR?

I am not sure to understand the question: I guess passing tests and hlt signature.

Does it impact validation for the production?

probably. PPD should clarify.

What is the timeline for HLT checks & validation of the updates in this PR

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

What is the timeline for HLT checks & validation of the updates in this PR.

This menu (with minor adjustments) took data at P5 in the last part of 2022. Provided it passes tests here I am not expecting it giving (technical) problems in production. As for the physics content I am not qualified to provide an answer. How was the previous version validated?

@antoniovilela
Copy link
Contributor

What is the timeline for HLT checks & validation of the updates in this PR.

This menu (with minor adjustments) took data at P5 in the last part of 2022. Provided it passes tests here I am not expecting it giving (technical) problems in production. As for the physics content I am not qualified to provide an answer. How was the previous version validated?

If there is a reason to use the previous version in production, I would say it is PPD's call. If the new version is good for production and does not delay things due to validation, then I would wait for the PR to be merged (maybe still today) ?

@antoniovilela
Copy link
Contributor

We have started a patch build without this, we can make a new patch if agreed by all parties (PPD & Trigger coordination).

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

Pull request #45939 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35537f/41381/summary.html
COMMIT: 8d33e25
CMSSW: CMSSW_12_4_HLT_X_2024-09-01-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45939/41381/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 06-Sep-2024 18:06:40 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'HLT_PFMET110_PFJet100_v3'
   [2] Calling method for module HLTL1TSeed/'hltL1sETMHF90SingleJet60looseRecoiling'
Exception Message:

Algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 06-Sep-2024 18:17:50 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_PFMET110_PFJet100_v3'
   [2] Calling method for module HLTL1TSeed/'hltL1sETMHF90SingleJet60looseRecoiling'
Exception Message:

Algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 06-Sep-2024 18:18:06 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_PFMET110_PFJet100_v3'
   [2] Calling method for module HLTL1TSeed/'hltL1sETMHF90SingleJet60looseRecoiling'
Exception Message:

Algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_ETMHF80_SingleJet55er2p5_dPhi_Min2p1 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

Ok 8d33e25 cannot work on the relvals without more complicated changes involving conditions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35537f/41385/summary.html
COMMIT: e387db6
CMSSW: CMSSW_12_4_HLT_X_2024-09-01-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45939/41385/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3764887
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3764851
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -308.308 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): -308.312 KiB HLT/EGM
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 6, 2024

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_HLT_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 014e5fa into cms-sw:CMSSW_12_4_HLT_X Sep 10, 2024
9 checks passed
@mmusich mmusich deleted the HLTDevelopment124X branch September 10, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants