-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.4_HLT_X
] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5
#45939
[12.4_HLT_X
] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5
#45939
Conversation
A new Pull Request was created by @mmusich for CMSSW_12_4_HLT_X. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild, please test |
12.4.4_HLT_X
] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5
12.4.4_HLT_X
] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.512.4_HLT_X
] HLT configurations for 2022 MC: from menu 2022 V1.4 to menu 2022 V1.5
Hi @mmusich , thanks for the PR. Is it possible to keep v1.4 in, or are the changes in the v1.5 menu incompatible ? |
It is possible, I'd rather not, given the amount of confusion that having multiple menus has created in PdmV. |
please keep v1.4 around ; never mind the confusion |
please provide a justification. |
for the Summer24 MC production for 2022, we would like to keep the option of choosing between v1.4 and v1.5, even though the v1.5 option is preferred |
I would think this decision is ultimately a TSG one. When I get word from TSG coordination to keep V1.4 I'll comply. |
agreed. |
I beg to disagree, because any mistakes in the L1T+HLT configuration would need then to be ultimately debugged by TSG experts, thus I would tend to minimize the amount of effort we need to spend on it. |
What is missing for this PR? Does it impact validation for the production? |
I am not sure to understand the question: I guess passing tests and
probably. PPD should clarify. |
What is the timeline for HLT checks & validation of the updates in this PR |
This menu (with minor adjustments) took data at P5 in the last part of 2022. Provided it passes tests here I am not expecting it giving (technical) problems in production. As for the physics content I am not qualified to provide an answer. How was the previous version validated? |
If there is a reason to use the previous version in production, I would say it is PPD's call. If the new version is good for production and does not delay things due to validation, then I would wait for the PR to be merged (maybe still today) ? |
We have started a patch build without this, we can make a new patch if agreed by all parties (PPD & Trigger coordination). |
Pull request #45939 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again. |
@cmsbuild, please test |
-1 Failed Tests: RelVals RelVals
|
Ok 8d33e25 cannot work on the relvals without more complicated changes involving conditions. |
8d33e25
to
e387db6
Compare
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35537f/41385/summary.html Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_HLT_X IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Development of HLT menu for
CMSSW_12_4_HLT_X
.This update is meant exclusively for the Summer2024 production of Run 3 MC.
This PR is NOT a backport.
This version of the GRun Frozen HLT menu corresponds to to the "V1.5" menu for the 2022 pp data-taking period. The older version "V1.4" is removed. All TSG integration tests are updated accordingly.
This update includes the integration of the following JIRA tickets:
HLT_ZeroBias_Alignment_v*
)DeepCSV
triggers ofGRun
HLT_EphemeralZeroBias
changed toL1_ZeroBias_copy
suppressWarning
listHLT_HT300_Beamspot
triggerHLT_EphemeralPhysics
(L1A Physics "masking" L1_ZeroBias_copy)L1_SingleTau130er2p1
to L1T seeds usingL1_SingleTau120er2p1
AlCa_*PFJet*
triggersMC_Run3_PFScoutingPixelTracking_v
PathThis corresponds to the updates to the
GRun
subtable as in #39679 and #39926In addition, commit 8d33e25 removes support for the frozen menu 2022 V1.2, unused for the Summer24 MC production.
PR validation:
TSG integration tests
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not to be forward-ported.