Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECAL DCC desync DQM trend plots and update the DQM threshold for Integrity summary [14_1_X] #45933

Merged
merged 2 commits into from
Sep 9, 2024
+73 −11
Merged

Add ECAL DCC desync DQM trend plots and update the DQM threshold for Integrity summary [14_1_X] #45933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e0c40f
Add ECAL DCC desync DQM trend plots
Aug 21, 2024
17c1632
Update ECAL DCC number of desyncs threshold for Integrity Quality Cri…
Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DQM/EcalMonitorClient/python/IntegrityClient_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
kind = cms.untracked.string('TH2F'),
otype = cms.untracked.string('Ecal3P'),
btype = cms.untracked.string('Crystal'),
description = cms.untracked.string('Summary of the data integrity. A channel is red if more than ' + str(errFractionThreshold) + ' of its entries have integrity errors.')
description = cms.untracked.string('Summary of the data integrity. A channel is red if more than ' + str(errFractionThreshold) + ' of its entries have integrity errors. Also, an entire SuperModule can show red if more than 0.01 of its entries have DCC-SRP or DCC-TCC Desync errors.')
),
Quality = cms.untracked.PSet(
path = cms.untracked.string('%(subdet)s/%(prefix)sIntegrityClient/%(prefix)sIT data integrity quality %(sm)s'),
Expand Down
16 changes: 12 additions & 4 deletions DQM/EcalMonitorClient/src/IntegrityClient.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,15 +123,23 @@ namespace ecaldqm {
}
}

// Quality check: set an entire FED to BAD if "any" DCC-SRP or DCC-TCC mismatch errors are detected
// Quality check: set an entire FED to BAD if "any" DCC-SRP or DCC-TCC mismatch errors are detected AND the number of events affected by the DCC-SRP or DCC-TCC mismatch errors is more than 1% of the events analyzed in the run
// Fill mismatch statistics
MESet const& sBXSRP(sources_.at("BXSRP"));
MESet const& sBXTCC(sources_.at("BXTCC"));
std::vector<bool> hasMismatchDCC(nDCC, false);
for (unsigned iDCC(0); iDCC < nDCC; ++iDCC) {
if (sBXSRP.getBinContent(getEcalDQMSetupObjects(), iDCC + 1) > 50. ||
sBXTCC.getBinContent(getEcalDQMSetupObjects(), iDCC + 1) > 50.) // "any" => 50
hasMismatchDCC[iDCC] = true;
int nBXSRPdesync = sBXSRP.getBinContent(getEcalDQMSetupObjects(), iDCC + 1);
int nBXTCCdesync = sBXTCC.getBinContent(getEcalDQMSetupObjects(), iDCC + 1);

if (nBXSRPdesync > 50. || nBXTCCdesync > 50.) { // "any" => 50
if (nBXSRPdesync > int(0.01 * processedEvents) ||
nBXTCCdesync >
int(0.01 *
processedEvents)) { // check if the events with DCC-SRP or DCC-TCC desyncs for the given DCC is more than 1% of the events analyzed
hasMismatchDCC[iDCC] = true;
}
}
}
// Analyze mismatch statistics
for (MESet::iterator qsItr(meQualitySummary.beginChannel(GetElectronicsMap()));
Expand Down
28 changes: 28 additions & 0 deletions DQM/EcalMonitorTasks/python/RawDataTask_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,34 @@

ecalRawDataTask = cms.untracked.PSet(
MEs = cms.untracked.PSet(
TrendBXTCC = cms.untracked.PSet(
path = cms.untracked.string('Ecal/Trends/RawDataTask number of %(prefix)sRDT bunch crossing TCC errors'),
kind = cms.untracked.string('TH1F'),
otype = cms.untracked.string('Ecal2P'),
btype = cms.untracked.string('Trend'),
description = cms.untracked.string('Trend of the number of bunch crossing value mismatches between DCC and TCC.')
),
TrendL1ATCC = cms.untracked.PSet(
path = cms.untracked.string('Ecal/Trends/RawDataTask number of %(prefix)sRDT L1A TCC errors'),
kind = cms.untracked.string('TH1F'),
otype = cms.untracked.string('Ecal2P'),
btype = cms.untracked.string('Trend'),
description = cms.untracked.string('Trend of the number of L1A value mismatches between DCC and TCC.')
),
TrendBXSRP = cms.untracked.PSet(
path = cms.untracked.string('Ecal/Trends/RawDataTask number of %(prefix)sRDT bunch crossing SRP errors'),
kind = cms.untracked.string('TH1F'),
otype = cms.untracked.string('Ecal2P'),
btype = cms.untracked.string('Trend'),
description = cms.untracked.string('Trend of the number of bunch crossing value mismatches between DCC and SRP.')
),
TrendL1ASRP = cms.untracked.PSet(
path = cms.untracked.string('Ecal/Trends/RawDataTask number of %(prefix)sRDT L1A SRP errors'),
kind = cms.untracked.string('TH1F'),
otype = cms.untracked.string('Ecal2P'),
btype = cms.untracked.string('Trend'),
description = cms.untracked.string('Trend of the number of L1A value mismatches between DCC and SRP.')
),
BXSRP = cms.untracked.PSet(
path = cms.untracked.string('%(subdet)s/%(prefix)sRawDataTask/%(prefix)sRDT bunch crossing SRP errors'),
kind = cms.untracked.string('TH1F'),
Expand Down
38 changes: 32 additions & 6 deletions DQM/EcalMonitorTasks/src/RawDataTask.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ namespace ecaldqm {
MESet& meBXSRP(MEs_.at("BXSRP"));
MESet& meL1ASRP(MEs_.at("L1ASRP"));
MESet& meTrendNSyncErrors(MEs_.at("L1ATCC"));
MESet& meTrendBXTCC(MEs_.at("TrendBXTCC"));
MESet& meTrendL1ATCC(MEs_.at("TrendL1ATCC"));
MESet& meTrendBXSRP(MEs_.at("TrendBXSRP"));
MESet& meTrendL1ASRP(MEs_.at("TrendL1ASRP"));
MESet& meEventTypePreCalib(MEs_.at("EventTypePreCalib"));
MESet& meEventTypeCalib(MEs_.at("EventTypeCalib"));
MESet& meEventTypePostCalib(MEs_.at("EventTypePostCalib"));
Expand Down Expand Up @@ -214,30 +218,52 @@ namespace ecaldqm {
if (tccBx.size() == 4) { // EB uses tccBx[0]; EE uses all
if (dccId <= kEEmHigh + 1 || dccId >= kEEpLow + 1) {
for (int iTCC(0); iTCC < 4; iTCC++) {
if (tccBx[iTCC] != dccBX && tccBx[iTCC] != -1 && dccBX != -1)
if (tccBx[iTCC] != dccBX && tccBx[iTCC] != -1 && dccBX != -1) {
meBXTCC.fill(getEcalDQMSetupObjects(), dccId);
meTrendBXTCC.fill(getEcalDQMSetupObjects(), EcalEndcap, double(timestamp_.iLumi), 1);
}

if (tccL1[iTCC] != dccL1AShort && tccL1[iTCC] != -1 && dccL1AShort != 0)
if (tccL1[iTCC] != dccL1AShort && tccL1[iTCC] != -1 && dccL1AShort != 0) {
meL1ATCC.fill(getEcalDQMSetupObjects(), dccId);
meTrendL1ATCC.fill(getEcalDQMSetupObjects(), EcalEndcap, double(timestamp_.iLumi), 1);
}
}
} else {
if (tccBx[0] != dccBX && tccBx[0] != -1 && dccBX != -1)
if (tccBx[0] != dccBX && tccBx[0] != -1 && dccBX != -1) {
meBXTCC.fill(getEcalDQMSetupObjects(), dccId);
meTrendBXTCC.fill(getEcalDQMSetupObjects(), EcalBarrel, double(timestamp_.iLumi), 1);
}

if (tccL1[0] != dccL1AShort && tccL1[0] != -1 && dccL1AShort != 0)
if (tccL1[0] != dccL1AShort && tccL1[0] != -1 && dccL1AShort != 0) {
meL1ATCC.fill(getEcalDQMSetupObjects(), dccId);
meTrendL1ATCC.fill(getEcalDQMSetupObjects(), EcalBarrel, double(timestamp_.iLumi), 1);
}
}
}

short srpBx(dcchItr->getSRPBx());
short srpL1(dcchItr->getSRPLv1());

if (srpBx != dccBX && srpBx != -1 && dccBX != -1)
if (srpBx != dccBX && srpBx != -1 && dccBX != -1) {
meBXSRP.fill(getEcalDQMSetupObjects(), dccId);

if (srpL1 != dccL1AShort && srpL1 != -1 && dccL1AShort != 0)
if (dccId <= kEEmHigh + 1 || dccId >= kEEpLow + 1) { // EE
meTrendBXSRP.fill(getEcalDQMSetupObjects(), EcalEndcap, double(timestamp_.iLumi), 1);
} else { // EB
meTrendBXSRP.fill(getEcalDQMSetupObjects(), EcalBarrel, double(timestamp_.iLumi), 1);
}
}

if (srpL1 != dccL1AShort && srpL1 != -1 && dccL1AShort != 0) {
meL1ASRP.fill(getEcalDQMSetupObjects(), dccId);

if (dccId <= kEEmHigh + 1 || dccId >= kEEpLow + 1) { // EE
meTrendL1ASRP.fill(getEcalDQMSetupObjects(), EcalEndcap, double(timestamp_.iLumi), 1);
} else { // EB
meTrendL1ASRP.fill(getEcalDQMSetupObjects(), EcalBarrel, double(timestamp_.iLumi), 1);
}
}

const int calibBX(3490);

short runType(dcchItr->getRunType() + 1);
Expand Down