Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run3_data GT in autoCond from 140X_dataRun3_v4 to 140X_dataRun3_v9 #45879

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Sep 4, 2024

PR description:

This pull request upgrades the versioned GT for the dataRun3 in autoCond from 140X_dataRun3_v4 to 140X_dataRun3_v9.

The updates included in the various intermediate GT versions are the following:

It is intended that the updates integrated for the Run3 2022 and 2023 ReReco in 140X are not yet the final ones. But it is worth including the current status in autoCond nonetheless, so that it can be kept tested in the IBs.

PR validation:

Tested on a few workflows and unit tests, but I'd rely on the bot tests for a more extensive check

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport down to CMSSW_14_0_X will be provided

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Sep 4, 2024

please test

@mmusich
Copy link
Contributor

mmusich commented Sep 4, 2024

140X_dataRun3_v5 to 140X_dataRun3_v6, diff
Updated GT with SiPixel and TkAl conditions for 2022-2023 ReReco in 140X (See details in https://cms-talk.web.cern.ch/t/call-for-conditions-full-2022-2023-data-rereco-and-mc-production-in-140x/32887/26)

I am wondering if there is a specific reason to leave out the BeamSpot update (see details in https://cms-talk.web.cern.ch/t/call-for-conditions-full-2022-2023-data-rereco-and-mc-production-in-140x/32887/31).

I still see:

$ conddb list 140X_dataRun3_v8 | grep BeamSpot
[2024-09-04 17:51:16,969] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
BeamSpotObjectsRcd                                      -                                                              BeamSpotObjects_Run3_LumiBased_v1                      

(and not v2, which is the version I would expect from the cmsTalk).
Without the beamspot update, but the block of tracker conditions, track reconstruction will be biased.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

Pull request #45879 was updated. @cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please check and sign again.

@perrotta
Copy link
Contributor Author

perrotta commented Sep 4, 2024

I am wondering if there is a specific reason to leave out the BeamSpot update (see details in https://cms-talk.web.cern.ch/t/call-for-conditions-full-2022-2023-data-rereco-and-mc-production-in-140x/32887/31).

Good point @mmusich , thank you for noticing, That tag was indeed forgotten once updating for v6.
I warned in the description that the GT was not yet final for that re-reco campaign, but it is correct to update it with the beamspot, not to bias the track reconstruction, as you correctly wrote.
I have updated the offline GT to v9, and I'm going to update the PR description here too.

@perrotta
Copy link
Contributor Author

perrotta commented Sep 4, 2024

please test

@mmusich
Copy link
Contributor

mmusich commented Sep 4, 2024

I have updated the offline GT to v9, and I'm going to update the PR description here too.

thanks a lot!

@perrotta perrotta changed the title Update run3_data GT in autoCond from 140X_dataRun3_v4 to 140X_dataRun3_v8 Update run3_data GT in autoCond from 140X_dataRun3_v4 to 140X_dataRun3_v9 Sep 4, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2c01f1/41298/summary.html
COMMIT: 0b9a5bf
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45879/41298/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 6816 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328501
  • DQMHistoTests: Total failures: 1241
  • DQMHistoTests: Total nulls: 11
  • DQMHistoTests: Total successes: 3327229
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.028 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 140.023 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.016 KiB JetMET/SUSYDQM
  • Checked 193 log files, 163 edm output root files, 44 DQM output files
  • TriggerResults: found differences in 1 / 42 workflows

@perrotta
Copy link
Contributor Author

perrotta commented Sep 5, 2024

+1

  • Reco and DQm comparisons look consequential to the changes in the conditions in the GT

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants