CICADA-Calo Layer 1 Packer

[aloeliger]

PR description:

This PR adds a packer for the CICADA data as transmitted by the Calo Layer 1 system. This should be the counterpart to the Calo Layer 1 Unpacker added as a part of #45293.

@slaurila @eyigitba FYI.

PR validation:

All code compiles and has had formatting appllied. The DIGI2RAW step has been checked on MC, and the packer is called appropriately, and produces the expected output for input scores:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is not a backport, but will likely require backports all the way to CMSSW_14_0.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45863/41608

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45863/41608/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45863/41608/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[aloeliger]

thought I applied code-format anyways.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45863/41610

[cmsbuild]

A new Pull Request was created by @aloeliger for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@aloeliger, @cmsbuild, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @eyigitba, @missirol, @mmusich, @thomreis this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d386/41280/summary.html
COMMIT: 1479f35
CMSSW: CMSSW_14_2_X_2024-09-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45863/41280/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 7.3A fatal system signal has occurred: segmentation violation
• 1306.0A fatal system signal has occurred: segmentation violation
• 1330.0A fatal system signal has occurred: segmentation violation

Expand to see more relval errors ...

• 312.0
• 25202.0
• 11634.0
• 12434.0
• 10224.0
• 12834.0
• 12846.0
• 12834.7
• 13034.0
• 250202.181

[aloeliger]

I have lost access to the test results to help me debug the segfault here. Just going to try and get access to those again.

[aloeliger]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41d386/41558/summary.html
COMMIT: 1479f35
CMSSW: CMSSW_14_2_X_2024-09-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45863/41558/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 7.3A fatal system signal has occurred: segmentation violation
• 1306.0A fatal system signal has occurred: segmentation violation
• 1330.0A fatal system signal has occurred: segmentation violation

Expand to see more relval errors ...

• 312.0
• 25202.0
• 11634.0
• 12434.0
• 10224.0
• 12834.0
• 12846.0
• 12834.7
• 13034.0
• 250202.181

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_15_0_X. Please open a backport if it should also go in to CMSSW_14_2_X.