Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Add option to sort candidates by pT in Unified Particle Transformer #45846

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

Backport of #45843

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for CMSSW_13_2_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @andrzejnovak, @castaned, @demuller, @hqucms, @missirol this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 31, 2024

cms-bot internal usage

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

This PR is not identical to the other backport https://github.com/cms-sw/cmssw/pull/45847/files and does not emulate #45843
Why fix_lt_sorting is not included here?

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Sep 2, 2024

This PR is not identical to the other backport https://github.com/cms-sw/cmssw/pull/45847/files and does not emulate #45843
Why fix_lt_sorting is not included here?

It is identical to the backport made to 14_1_X. It is not identical to the backport to 14_0_X because that one contains two PRs (the PR related to pT sorting and the PR that fixes the sorting index).

And regarding the fix of the sorting index, it has already been backported directly (without a flag) to 13_2_X since there were no models trained yet with the bug (the models for pp were trained for 14_0_X).

@stahlleiton
Copy link
Contributor Author

stahlleiton commented Sep 2, 2024

This PR is not identical to the other backport https://github.com/cms-sw/cmssw/pull/45847/files and does not emulate #45843
Why fix_lt_sorting is not included here?

It is identical to the backport made to 14_1_X. It is not identical to the backport to 14_0_X because that one contains two PRs.

And regarding the fix, it has already been backported directly (without a flag) to 13_2_X since there were no models trained yet with the bug (the models for pp were trained for 14_0_X).

The fix of the sorting index was partially back ported to 13_2_X in this PR: #45700

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-076d9a/41232/summary.html
COMMIT: 6b0858f
CMSSW: CMSSW_13_2_X_2024-09-01-0000/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45846/41232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198830
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198802
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 88fe605 into cms-sw:CMSSW_13_2_X Sep 10, 2024
9 checks passed
@stahlleiton stahlleiton deleted the UParT_PtSort_CMSSW_13_2_X branch October 23, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants