-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TauSpinner weight table producer for HTT #45828
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45828/41568 |
A new Pull Request was created by @mbluj for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable nano |
src = 'prunedGenParticles', | ||
name = 'TauSpinner', | ||
theta = [0, 0.25, 0.5, -0.25, 0.375], | ||
pdfSet = 'NNPDF31_nnlo_hessian_pdfas', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is the pdfSet
used? Does it need to match the PDF used in the sample production?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that PDFSet used by TauSpinner is relevant when TauSpinner is used to weight Z polarization, but not in the case of CP in the H->tau,tau decays. I will check it and confirm here.
After said this, I think that it will be good to match it with PDF used for sample production, but I don't think it is possible to check it automatically. Is it possible. Anyway, is it not NNPDF 3.1 NNLO which is used by default in current MC productions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it again and I confirm that PDFSet
and cmsE
are important only for weighting Z/gamma* events. It is as polarization of Z/gamma* and then taus from its decays depends on production process where PDFSet
and cmsE
are important inputs. It is not the case for H->tau,tau.
As an "experimental" confirmation of this fact I ran the module with three different PDF sets and different collision energy, and I got identical results.
Because the parameters are irrelevant, I will remove them from list of configurable parameters, and set them to "sensible" defaults with an appropriate comment. When one will want to extend the module for Z/gamma*->tau,tau will clearly know what should be done.
globalTablesTask = cms.Task(beamSpotTable, rhoTable) | ||
globalTablesMCTask = cms.Task(puTable,genTable,genFilterTable) | ||
globalTablesMCTask = cms.Task(puTable,genTable,genFilterTable,tauSpinnerTable) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to add this to genparticles_cff.py
instead of globals_cff
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TauSpinner weights are global event weights similar to weights for PDF set replicas, etc. But if you think that genparticles_cff.py
is better place for it I can move it - please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case it probably fits better in genWeightsTable_cfi.py
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll move it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking some thinking I found the the following:
- the
genWeightsTable_cfi.py
defines only one module (it iscfi
file), namelygenWeightsTable
producer, and adding other module into thiscfi
will be misleading (also because of the name of the file); - one can prepare a separate
cfi
file fortauSpinnerTable
producer (similar to thegenWeightsTable_cfi.py
) or keep the producer where it is, i.e. inglobals_cff.py
, as the TauSpinner weights are global in similar sense as generator weights stored bygenTable
producer. I prefer the latter option, but I will prepare a newcfi
if it is found better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, I decided to create a new dedicated cfi
file for tauSpinnerTable
producer.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45828/41575
|
Pull request #45828 was updated. @cmsbuild, @ftorrresd, @hqucms, @vlimant can you please check and sign again. |
ping |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds and enables in NanoAOD workflow a TauSpinner weight table producer for H->tau,tau samples. The TauSpinner weights allow to weight H->tau,tau events accordingly to different CP hypotheses.
The producer initializes the TauSpinner tool and then produces relevant weight tables only for events with the single-H->tau,tau decays, while for other event types tables are not produced. Therefore, size increase happens only for single-H->tau,tau samples and it is, with proposed setup with 5 different CP hypotheses and 2 weights per hypothesis, ~1.5% (measured with 1k VBF H->tau,tau events).
PR validation:
Validated with standard NanoAOD configuration with H->tau,tau and no H->tau,tau samples.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport to 14_1 series is foreseen.