Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_0] Fix for the cosmetic issue for the GEM DQM summary plot (backport) #45808

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Aug 27, 2024

PR description:

In this PR, a cosmetic bug in the GEM DQM summary plots has been fixed. The bug occurs because we did not take into account the effect of the multi-core environment on the storage of the geometry information in histograms. The geometry information will be retrieved correctly by this fix.

This is a backport of #45531 to 14_1_X.

PR validation:

Tests are done with runTheMatrix.py -l 141.107 with an additional run (367142) and runTheMatrix.py -l limited -i all --ibeos.

@jshlee @watson-ij @Dongwoon77

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

A new Pull Request was created by @quark2 for CMSSW_14_1_X.

It involves the following packages:

  • DQM/GEM (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Aug 27, 2024

backport of #45531

@tjavaid
Copy link

tjavaid commented Aug 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-adcfc2/41161/summary.html
COMMIT: c9b766a
CMSSW: CMSSW_14_1_X_2024-08-27-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45808/41161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 63
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328119
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 28, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

type gem

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b8d34ab into cms-sw:CMSSW_14_1_X Aug 31, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants