Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ECAL DCC desync DQM trend plots and update the DQM threshold for Integrity summary [14_0_13] #45761

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

kyungminparkdrums
Copy link

@kyungminparkdrums kyungminparkdrums commented Aug 21, 2024

PR description:

This PR includes two changes related to ECAL DQM:
[1] Adding the ECAL DQM plots for the trend of DCC-SRP and DCC-TCC desync in ECAL DQM (in Layout/01 Raw Data and Layout/11 Trend).
[2] Update the DQM threshold for the integrity summary for ECAL supermodule, such that if more than 1% of the supermodule has DCC-SRP or DCC-TCC desync errors it is flagged as bad (previous threshold: more than 50 desync errors).

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_0_13, which is used in production at the moment. Master PR is made in #45766

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2024

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_0_X.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)
  • DQM/EcalMonitorTasks (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 21, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

Pull request #45761 was updated. @antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@tjavaid
Copy link

tjavaid commented Aug 21, 2024

backport of #45766

@tjavaid
Copy link

tjavaid commented Aug 21, 2024

please test

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

please abort

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cc61f8/41312/summary.html
COMMIT: 8d788bc
CMSSW: CMSSW_14_0_X_2024-09-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45761/41312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 94 lines to the logs
  • Reco comparison results: 145 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3346637
  • DQMHistoTests: Total failures: 2717
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3343900
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 237.1949999999998 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 6.777 KiB Ecal/Trends
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Sep 5, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7ebd57b into cms-sw:CMSSW_14_0_X Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants