Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC13] Avoid Wdangling-reference warning in CalibTracker submodules #45732

Merged
merged 2 commits into from
Aug 19, 2024
Merged

[GCC13] Avoid Wdangling-reference warning in CalibTracker submodules #45732

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
575e336
Avoid Wdangling-reference warning in CalibTracker submodules
iarspider Aug 17, 2024
a3b77c7
Update CalibTracker/SiStripQuality/plugins/SiStripQualityHotStripIden…
iarspider Aug 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CalibTracker/SiStripCommon/plugins/TkDetMapESProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,8 @@ namespace {
} // namespace

std::unique_ptr<TkDetMap> TkDetMapESProducer::produce(const TrackerTopologyRcd& tTopoRcd) {
const auto& geomDet = tTopoRcd.getRecord<IdealGeometryRecord>().get(geomDetToken_);
const auto& geomDetRcd = tTopoRcd.getRecord<IdealGeometryRecord>();
const auto& geomDet = geomDetRcd.get(geomDetToken_);
const auto TkDetIdList = TrackerGeometryUtils::getSiStripDetIds(geomDet);

const auto& tTopo = tTopoRcd.get(tTopoToken_);
Expand Down
3 changes: 2 additions & 1 deletion CalibTracker/SiStripESProducers/plugins/fake/SiStripBackPlaneCorrectionFakeESSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ SiStripBackPlaneCorrectionFakeESSource::ReturnType SiStripBackPlaneCorrectionFak
const SiStripBackPlaneCorrectionRcd& iRecord) {
using namespace edm::es;

const auto& geomDet = iRecord.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
const auto& geomDet = geomDetRcd.get(m_geomDetToken);
const auto& tTopo = iRecord.get(m_tTopoToken);

auto backPlaneCorrection = std::make_unique<SiStripBackPlaneCorrection>();
Expand Down
3 changes: 2 additions & 1 deletion CalibTracker/SiStripESProducers/plugins/fake/SiStripHashedDetIdFakeESSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ std::unique_ptr<SiStripHashedDetId> SiStripHashedDetIdFakeESSource::produce(cons
edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"
<< " Building \"fake\" hashed DetId map from IdealGeometry";

const auto& geomDet = record.getRecord<TrackerDigiGeometryRecord>().get(geomDetToken_);
const auto& geomDetRcd = record.getRecord<TrackerDigiGeometryRecord>();
const auto& geomDet = geomDetRcd.get(geomDetToken_);

const std::vector<uint32_t> dets = TrackerGeometryUtils::getSiStripDetIds(geomDet);
edm::LogVerbatim("HashedDetId") << "[SiStripHashedDetIdFakeESSource::" << __func__ << "]"
Expand Down
3 changes: 2 additions & 1 deletion CalibTracker/SiStripESProducers/plugins/fake/SiStripLorentzAngleFakeESSource.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ SiStripLorentzAngleFakeESSource::ReturnType SiStripLorentzAngleFakeESSource::pro
const SiStripLorentzAngleRcd& iRecord) {
using namespace edm::es;

const auto& geomDet = iRecord.getRecord<TrackerTopologyRcd>().get(m_geomDetToken);
const auto& geomDetRcd = iRecord.getRecord<TrackerTopologyRcd>();
const auto& geomDet = geomDetRcd.get(m_geomDetToken);
const auto& tTopo = iRecord.get(m_tTopoToken);

auto lorentzAngle = std::make_unique<SiStripLorentzAngle>();
Expand Down
3 changes: 2 additions & 1 deletion CalibTracker/SiStripQuality/plugins/SiStripQualityHotStripIdentifier.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ void SiStripQualityHotStripIdentifier::resetHistos() {
void SiStripQualityHotStripIdentifier::bookHistos() {
edm::LogInfo("SiStripQualityHotStripIdentifier") << " [SiStripQualityHotStripIdentifier::bookHistos] " << std::endl;
char hname[1024];
for (const auto& it : SiStripDetInfoFileReader::read(fp_.fullPath()).getAllData()) {
const auto info = SiStripDetInfoFileReader::read(fp_.fullPath());
iarspider marked this conversation as resolved.
Show resolved Hide resolved
for (const auto& it : info.getAllData()) {
sprintf(hname, "h_%d", it.first);
auto ref = ClusterPositionHistoMap.find(it.first);
if (ref == ClusterPositionHistoMap.end()) {
Expand Down