-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine RPCDigis Validation histograms #45702
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45702/41320 |
A new Pull Request was created by @jhgoh for master. It involves the following packages:
@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
@jhgoh , just to confirm the existing time plots are now made hidden with this PR from switch introduced for phase-II scenario, right ? |
Yes, the timing plots will be hidden in Run3, because they are valid only after the phase-II upgrade. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is a follow-up PR of the previous one #45029.
In this PR, we want to refine the RPCDigis validation plots.
There was a report in the RPC-DPG working meeting 14 Aug 2024: link to the slide
The proposed changes are
PR validation:
Performed tests on CMSSW_14_1_0_pre6 release
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
We want to have backport to the currently active release cycles
Possible watchers: @mileva @mrcthiel