Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added displaced muon information to the EMTF emulator DQM #45664

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

lrburack
Copy link
Contributor

@lrburack lrburack commented Aug 7, 2024

PR description:

The EMTF emulator DQM will now include the displaced muon pT and dxy information which was added to the EMTF in 2024. The code to make these plots already existed, but an era modifier to set 'hasDisplacementInfo' to true for 2024 Run3 data was necessary to make it appear.

There are two new DQM histograms showing unconstrained muon pT from the hardware and from the emulator.
The errorSummaryDen, errorSummaryNum, and mismatchRatio histograms have two new bins for unconstrained muon pt, and transverse displacement.

After inclusion of displaced muons, a much higher muon mismatch ratio should be expected because unconstrained muon pT assignment in the emulator slightly differs from the hardware due to fixed point vs floating point models. A normal unconstrained pT mismatch rate is high in the EMTF (~30%).

PR validation:

The DQM was successfully run locally on lxplus
dataset='/Muon0/Run2024F-ZMu-PromptReco-v1/RAW-RECO'
run='383449'
runTheMatrix.py -l limited -i all --ibeos: all passed except 1000.0_RunMinBias2011A which has a known issue when CMSSW is run from eos.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is expected to be backported to 14_0_X so that it can be used in data taking.

@eyigitba

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2024

A new Pull Request was created by @lrburack for master.

It involves the following packages:

  • DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Aug 8, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2024

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54adcc/40831/summary.html
COMMIT: 0dd6aff
CMSSW: CMSSW_14_1_X_2024-08-07-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45664/40831/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • Reco comparison results: 98 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3423977
  • DQMHistoTests: Total failures: 2466
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 3421483
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 16.984 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): 4.246 KiB L1TEMU/L1TdeStage2EMTF
  • Checked 196 log files, 165 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Aug 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants