-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Introduce BeamSpotCompatibilityChecker
and corresponding tests
#45637
[14.0.X] Introduce BeamSpotCompatibilityChecker
and corresponding tests
#45637
Conversation
… event w.r.t the one from the data-base
A new Pull Request was created by @mmusich for CMSSW_14_0_X. It involves the following packages:
@cmsbuild, @consuegs, @jfernan2, @mandrenguyen, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild, please test |
+1 Size: This PR adds an extra 12KB to repository Comparison SummarySummary:
|
+1
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #45589
PR description:
The goal of this PR is to introduce
BeamSpotCompatibilityChecker
anedm::global::EDAnalyzer
designed to compare the Beam Spot payload in the Database with the one (potentially) available as a collection in the input data.Two thresholds are available:
This is useful when e.g. refitting tracks from file and using a
GlobalTag
(too much) different from the one used for the processing. This would allow the user to catch the configuration mistake and correct it.I add in this PR few unit tests (both
catch2
and from event data) for the novel functionality.PR validation:
Run
scram b runtests
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Verbatim backport of #45589 to the 2024 data-taking release.