-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L1TCaloLayer1Summary and necessary changes to emulator #45605
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45605/41097 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45605/41098 |
A new Pull Request was created by @max-zhao0 for master. It involves the following packages:
@aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45605/41101 |
Pull request #45605 was updated. @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again. |
Commit added that simplifies the emulator sequence and adds clarifications to plot titles, as requested by L1. Emulator sequence now now simulates and defines only the necessary digis for CaloLayer1. |
please test |
Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X. |
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
|
+l1 |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
Backport for 14_1_X created here: 45831 |
+1 |
PR description:
New DQM Analyzer for L1T Calorimeter Layer 1. Generates plots for CaloLayer1 Regions and CICADA Score, comparing DAQ data to emulator output. Also makes necessary changes to the CICADA emulator to allow for configurable source for regions.
PR validation:
Validated locally on CMSSW_14_1_0_pre5, running DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified for testing on lxplus. Also validated for online running in online DQM playback test.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is meant for future backporting to CMSSW_14_0_12 for online running.