Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1TCaloLayer1Summary and necessary changes to emulator #45605

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

max-zhao0
Copy link

@max-zhao0 max-zhao0 commented Jul 31, 2024

PR description:

New DQM Analyzer for L1T Calorimeter Layer 1. Generates plots for CaloLayer1 Regions and CICADA Score, comparing DAQ data to emulator output. Also makes necessary changes to the CICADA emulator to allow for configurable source for regions.

PR validation:

Validated locally on CMSSW_14_1_0_pre5, running DQM/Integration/python/clients/l1tstage2_dqm_sourceclient-live_cfg.py modified for testing on lxplus. Also validated for online running in online DQM playback test.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is meant for future backporting to CMSSW_14_0_12 for online running.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2024

cms-bot internal usage

@max-zhao0 max-zhao0 marked this pull request as draft July 31, 2024 10:30
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45605/41097

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@aloeliger
Copy link
Contributor

@eyigitba @slaurila FYI on CICADA DQM.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @max-zhao0 for master.

It involves the following packages:

  • DQM/Integration (dqm)
  • DQM/L1TMonitor (dqm)
  • L1Trigger/L1TCaloLayer1 (l1)

@aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @batinkov, @francescobrivio, @missirol, @mmusich, @threus this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
DQM/L1TMonitor/src/L1TCaloLayer1Summary.cc Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45605 was updated. @aloeliger, @antoniovagnerini, @cmsbuild, @epalencia, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please check and sign again.

@max-zhao0
Copy link
Author

Commit added that simplifies the emulator sequence and adds clarifications to plot titles, as requested by L1. Emulator sequence now now simulates and defines only the necessary digis for CaloLayer1.

@tjavaid
Copy link

tjavaid commented Aug 27, 2024

please test

@cmsbuild
Copy link
Contributor

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

@cmsbuild cmsbuild modified the milestones: CMSSW_14_1_X, CMSSW_14_2_X Aug 27, 2024
@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5e2a2/41148/summary.html
COMMIT: 83fe29e
CMSSW: CMSSW_14_1_X_2024-08-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45605/41148/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 109 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328202
  • DQMHistoTests: Total failures: 3158
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3325024
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6411.173999999998 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 305.294 KiB L1T/L1TCaloLayer1Summary
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@tjavaid
Copy link

tjavaid commented Aug 28, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@max-zhao0
Copy link
Author

+1

Backport for 14_1_X created here: 45831

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a08cd11 into cms-sw:master Aug 29, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants