Remove edmAddClassVersion script as obsolete

[makortel]

PR description:

I was starting to look into moving edmAddClassVersion to FWCore/Reflection, adding tests, and updating it to use the common facilities as a follow-up to #45423. Then I noticed the script tries to use gccxml, via scram tool info gccxml. Scram does not provide such a tool, and therefore the script can not function. (digging from history it was removed in cms-sw/cmsdist#1581, so maybe the script has been obsolete since we moved to ROOT6?)

Given the present situation I'd just remove the script.

Resolves cms-sw/framework-team#972

PR validation:

I checked with git grep that nothing in CMSSW itself refers to edmAddClassVersion. I search in the cms-sw GitHub organization and found nothing referring to it (beyond the code itself in three copies of the framework), whereas search for edmCheckClassVersion shows many hits.

Twiki search shows a reference in https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideCreatingNewProducts#Class_versioning, which I'll update.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45584/41087

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• FWCore/Utilities (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@felicepantaleo, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@smuzaffar @Dr15Jones Any objections?

[makortel]

@cmsbuild, please test

(a bit pointless, but anyway)

[Dr15Jones]

What does edmAddClassVersion do that is markedly different from edmCheckClassVersion?

[makortel]

On a quick look the main difference seems to be that edmAddClassVersion operates on classes defined in classes_def.xml that are not templates and do not have ClassVersion attribute in the <class> element. It generates a new classes_def.xml file with the class versions added to the <class> elements (starting with class version 10).

I think we should add similar check (non-template-instantiations to have a class version) to our tests. I was first thinking to make this "new non-template class added, should start version number from 3" as part of the policy checks done by the checkDictionaryUpdate.py script (that operates on the JSON output of edmDumpClassVersion), but I'm now thinking if the check could be added to edmCheckClassVersion directly (in which case already scram b on a developer area would catch it).

[Dr15Jones]

So maybe the edmAddClassVersion was there to fixup old code. So I'm OK with removing it.

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4aea13/40684/summary.html
COMMIT: 8ac90aa
CMSSW: CMSSW_14_1_X_2024-07-29-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45584/40684/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 175 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 314
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3423627
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@smuzaffar @Dr15Jones Any objections?

@makortel , no objections on dropping edmAddClassVersion.

[makortel]

So maybe the edmAddClassVersion was there to fixup old code.

This is my impression as well

[makortel]

Comparison differences are related to #45505

[makortel]

+core

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1