Use uncorrected H/E for electron energy regressions: 140X

[Sam-Harper]

PR description:

This is a bug fix and backport of #45470

Please see that PR for the full details of the bug fix. Summary, the E/gamma energy regression is using the wrong H/E value.

This PR makes it use the uncorrected value. This is the correct value for UL Run2 samples and the upcoming 2024 regression.

This is the wrong value for current Run3 regression but the current variable is also wrong for the Run3 regression so this is just different wrong.

The effect on real electrons, particularly those well measured, should be small. The effect on jets and missmeasured electrons is higher but the value should be comparible physics wise to the old one.

PR validation:

tested as part of:
#45470

[cmsbuild]

A new Pull Request was created by @Sam-Harper for CMSSW_14_0_X.

It involves the following packages:

• RecoEgamma/EgammaTools (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@Prasant1993, @a-kapoor, @afiqaize, @jainshilpi, @lgray, @missirol, @ram1123, @sameasy, @sobhatta, @valsdav, @varuns23 this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Use uncorrected H/E for electron energy regressions #45470

[cmsbuild]

cms-bot internal usage

[mandrenguyen]

please test

[mandrenguyen]

type bug-fix, egamma

[mandrenguyen]

backport of #45470

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1cdb6f/40527/summary.html
COMMIT: b2497be
CMSSW: CMSSW_14_0_X_2024-07-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45526/40527/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 94 lines to the logs
• Reco comparison results: 3497 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342828
• DQMHistoTests: Total failures: 7258
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3335550
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
As per #45470 (comment) we plan to merge this into the production release even though it changes reconstruction.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1