-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L1] Fix Warnings: Remove unused variables #45481
Conversation
please test with cms-sw/cms-bot#2296 |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45481/40946
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@aloeliger, @epalencia can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cms-sw/l1-l2 , can you please review this? This removes the unused variables which were left behind when some code was cleaned up in #44498 . This should fix the compilation warning for 14.1.X IBs |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
+1 Size: This PR adds an extra 28KB to repository
Comparison SummarySummary:
|
@cms-sw/orp-l2 , can you please review and approve this? This should fix the compilation warnings for 14.1.X IBs |
+1 |
This PR fixes the compilation warnings by removing the unused variables
[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_ROOT6_X_2024-07-16-2300/L1Trigger/Phase2L1GMT