Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[L1] Fix Warnings: Remove unused variables #45481

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jul 17, 2024

This PR fixes the compilation warnings by removing the unused variables

[a] https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/el8_amd64_gcc12/CMSSW_14_1_ROOT6_X_2024-07-16-2300/L1Trigger/Phase2L1GMT

src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc: In member function 'virtual void Phase2L1TGMTStubProducer::produce(edm::Event&, const edm::EventSetup&)':
  src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc:114:8: warning: unused variable 'count0' [-Wunused-variable]
   114 |   uint count0 = 0;
      |        ^~~~~~
  src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc:115:8: warning: unused variable 'count1' [-Wunused-variable]
   115 |   uint count1 = 0;
      |        ^~~~~~
  src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc:116:8: warning: unused variable 'count2' [-Wunused-variable]
   116 |   uint count2 = 0;
      |        ^~~~~~
  src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc:117:8: warning: unused variable 'count3' [-Wunused-variable]
   117 |   uint count3 = 0;
      |        ^~~~~~
  src/L1Trigger/Phase2L1GMT/plugins/Phase2L1TGMTStubProducer.cc:118:8: warning: unused variable 'count4' [-Wunused-variable]
   118 |   uint count4 = 0;

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cms-bot#2296

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 17, 2024

cms-bot internal usage

@smuzaffar smuzaffar changed the title Fix Warnings: Remove unused variables [L1] Fix Warnings: Remove unused variables Jul 17, 2024
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45481/40946

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • L1Trigger/Phase2L1GMT (l1)

@aloeliger, @epalencia can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

@cms-sw/l1-l2 , can you please review this? This removes the unused variables which were left behind when some code was cleaned up in #44498 . This should fix the compilation warning for 14.1.X IBs

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cms-bot#2296

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3734e8/40451/summary.html
COMMIT: 7c417cc
CMSSW: CMSSW_14_1_X_2024-07-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45481/40451/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345094
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345068
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , can you please review and approve this? This should fix the compilation warnings for 14.1.X IBs

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 5b527ae into cms-sw:master Jul 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants