Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] L1 Scouting Online Selection modules #45451

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Mmiglio
Copy link
Contributor

@Mmiglio Mmiglio commented Jul 15, 2024

PR description:

Backport of #45350

This PR introduces the modules used for the L1 Scouting Online selection, which will complement the "Zero bias" stream.
The selection stream was discussed during L1 Trigger DPG meetings (e.g. link)

PR validation:

The PR has been validate using recent files collected in the "Zero Bias" stream, e.g.

cmsRun test/L1ScoutingSelector.py inFile=file:root://xrootd-cms.infn.it///store/data/Run2024F/L1Scouting/L1SCOUT/v1/000/383/155/00000/7bab6f2b-924f-4702-83c1-70164122d317.root numOrbits=100 outFile=/tmp/dump.root

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45350 needed to add Online Selection modules to a release used for data taking.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Mmiglio for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/L1ScoutingRawToDigi (daq)
  • L1TriggerScouting/OnlineProcessing (l1, daq)

@aloeliger, @cmsbuild, @emeschi, @epalencia, @smorovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @dinyar, @missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2024

cms-bot internal usage

@epalencia
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8e6c8/40400/summary.html
COMMIT: dd9b2b8
CMSSW: CMSSW_14_0_X_2024-07-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45451/40400/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smorovic
Copy link
Contributor

+1

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 56adf73 into cms-sw:CMSSW_14_0_X Jul 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants