Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store track momentum at hit for PbPb UPC dEdX calibration #45446

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR creates a value map containing the magnitude of the track global momentum at each hit needed to perform the dEdx calibration for PbPb UPC. This value map is only produced and stored when using the run3_upc era modifier.

@mandrenguyen @sikler

PR validation:

Tested with relvals 180, 180.1, 181, 181.1 and 142.901

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoTracker/DeDx (reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @GiacomoSguazzoni, @JanFSchulte, @Ming-Yan, @Senphy, @VinInn, @VourMa, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @dgulhan, @felicepantaleo, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @rappoccio, @rovere, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #45446 was updated. @cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please check and sign again.

@vlimant
Copy link
Contributor

vlimant commented Jul 15, 2024

+1
looks ok on the end

@mandrenguyen
Copy link
Contributor

please abort

@mandrenguyen
Copy link
Contributor

please test workflow 180, 180.1, 181, 181.1, 142.901

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4d9518/40395/summary.html
COMMIT: 5f1453a
CMSSW: CMSSW_14_1_X_2024-07-15-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45446/40395/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 3917343
  • DQMHistoTests: Total failures: 857
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3916466
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 53 files compared)
  • Checked 229 log files, 188 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1
Only affects dedicated UPC era.
Let's see if this signature triggers reco and ORP

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+orp

@mandrenguyen
Copy link
Contributor

+1
Checking if I can trigger the ORP flag now

@smuzaffar
Copy link
Contributor

@mandrenguyen , I will check why bot is not recognizing your signatures

@cmsbuild cmsbuild merged commit 751fa4f into cms-sw:master Jul 16, 2024
11 checks passed
@stahlleiton stahlleiton deleted the DeDxMomentum_CMSSW_14_1_X branch July 16, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants