MTD Validation: update of the BTL SimHit validation

[casarsa]

This PR updates the BtlSimHitsValidation plugin adding new monitoring histograms for hits produced by different trackIDs in the same BTL crystals.

The new histograms add 6 kB to the output DQM rootfile:
new file size: 267.81 KiB MTD/BTL
old file size: 261.81 KiB MTD/BTL

PR validation:

The updated validation code has been tested in the CMSSW_14_1_0_pre5 release with the workflows 27634.0_TTbar_14TeV+2026D105, 27834.0_TTbar_14TeV+2026D105PU, and 27834.99_TTbar_14TeV+2026D105PU_PMXS1S2:
the new code produces identical histograms to the current SimHit validation, except for the histogram of the number of hits from different trackIDs in the same cell, which is now filled after the cut to the cell total energy.

A note about the workflow with premixing (27834.99_TTbar_14TeV+2026D105PU_PMXS1S2): in both the old and the new code, the SimHits of the pileup events are not seen by the SimHit validation. The replay doesn't seem to work in this case because we store the accumulated SimHits in the MTD premix.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45424/40874

[cmsbuild]

A new Pull Request was created by @casarsa for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6a54e/40332/summary.html
COMMIT: 1dc3f24
CMSSW: CMSSW_14_1_X_2024-07-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45424/40332/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 16 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345094
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345060
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 36.048 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 6.008 KiB MTD/BTL
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

type mtd

[fabiocos]

@cms-sw/dqm-l2 comments on this PR?

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1