Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nano relval matrix #45419

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Jul 10, 2024

PR description:

Updated NANO relval matrix:

  • updated workflows to 140X
  • added Run2UL reMINI + reNANO workflows
  • moved NANOGEN from relval_generator to relval_nano

Also added the support for NANOGEN with the autoNANO syntax:

  • from GEN inputs: -s NANO:@GEN --eventcontent NANOAOD
  • from MiniAOD: -s NANO:@GENFromMini --eventcontent NANOAOD

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 10, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Jul 10, 2024

enable nano

@hqucms
Copy link
Contributor Author

hqucms commented Jul 10, 2024

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45419/40864

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hqucms for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • PhysicsTools/NanoAOD (xpog)

@AdrianoDee, @ftorrresd, @hqucms, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @Martin-Grunewald, @fabiocos, @gpetruc, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals RelVals-INPUT RelVals-NANO
Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-565cc2/40322/summary.html
COMMIT: 3d0536d
CMSSW: CMSSW_14_1_X_2024-07-09-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45419/40322/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

ValueError: Undefined workflows: 2500.4

RelVals-INPUT

  • 2500.2372500.237_ScoutingNANOdata140Xrun3/step2_ScoutingNANOdata140Xrun3.log

RelVals-NANO

  • 2500.2372500.237_ScoutingNANOdata140Xrun3/step2_ScoutingNANOdata140Xrun3.log
  • 2500.9112500.911_DYToLL_M-50_13TeV_pythia8/step2_DYToLL_M-50_13TeV_pythia8.log
  • 2500.9132500.913_TTbar_Pow_LHE_13TeV/step3_TTbar_Pow_LHE_13TeV.log
Expand to see more relval errors ...

@vlimant
Copy link
Contributor

vlimant commented Jul 10, 2024

N.B : should we update ConfigBulder to hard remove NANOGEN since you include the support here ?

@hqucms
Copy link
Contributor Author

hqucms commented Jul 10, 2024

N.B : should we update ConfigBulder to hard remove NANOGEN since you include the support here ?

Done in e193249 now.

@hqucms
Copy link
Contributor Author

hqucms commented Jul 17, 2024

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 @cms-sw/operations-l2
Could you please review and sign? We would like to get this in asap. Thanks!

@srimanob
Copy link
Contributor

Hi @hqucms
As you change the way to call NanoGEN, would it be useful to add a workflow on it? I see you only remove the workflow of NanoGEN, but no new workflow on the new way. Thx.

@hqucms
Copy link
Contributor Author

hqucms commented Jul 17, 2024

@srimanob The NanoGEN workflows are moved from relval_generator to relval_nano now so we can test them with all other nano workflows together.

@srimanob
Copy link
Contributor

@srimanob The NanoGEN workflows are moved from relval_generator to relval_nano now so we can test them with all other nano workflows together.

Is it moved in this PR? Thx.

@hqucms
Copy link
Contributor Author

hqucms commented Jul 17, 2024

@srimanob The NanoGEN workflows are moved from relval_generator to relval_nano now so we can test them with all other nano workflows together.

Is it moved in this PR? Thx.

Yes - in these lines: https://github.com/cms-sw/cmssw/pull/45419/files#diff-aaca4437268e5c684a1042abc90e2cdd651a08b8c35f03cdd32060e8918f41e5R359-R367

@srimanob
Copy link
Contributor

+Upgrade

@AdrianoDee
Copy link
Contributor

+pdmv

@vlimant
Copy link
Contributor

vlimant commented Jul 22, 2024

@cms-sw/operations-l2 please sign

@rappoccio
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f6e0fc4 into cms-sw:master Jul 23, 2024
13 checks passed
@hqucms
Copy link
Contributor Author

hqucms commented Jul 24, 2024

@cms-sw/core-l2 I noticed that the updated wf 2500.245 is failing because the input file [1] has disappeared from disk (now only on tape).

I would expect it to be automatically cached by ibeos but it seems no? How is the ibeos caching supposed to work for new input files?

[1] /store/data/Run2024F/TestEnablesEcalHcal/RAW/Express-v1/000/383/173/00000/1088fbe0-c256-4752-992c-0e535b804bef.root

@makortel
Copy link
Contributor

(@smuzaffar please correct me) I believe the ibeos caching works automatically for files that are on disk. I don't think we have any automated way to recall a file from tape (but I believe we could shovel the file to the cache by hand if that's what is needed).

In any case someone has to recall the file from tape. If the recall is done such that the file is visible e.g. via the xrootd redirectors (e.g. for a week or two), I'd expect the automatic caching to pick the file from there.

@smuzaffar
Copy link
Contributor

/store/data/Run2024F/TestEnablesEcalHcal/RAW/Express-v1/000/383/173/00000/1088fbe0-c256-4752-992c-0e535b804bef.root is now in ibeos cache

@hqucms
Copy link
Contributor Author

hqucms commented Jul 25, 2024

Thanks a lot @smuzaffar @makortel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants