Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GTs and modifiers for L1T 2024 menu L1Menu_Collisions2024_v1_3_0_xml #45389

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

perrotta
Copy link
Contributor

@perrotta perrotta commented Jul 5, 2024

Update L1T menu in the 2024 MC GTs with L1Menu_Collisions2024_v1_3_0_xml, as from cmsTalk, as well as the modifier for the L1T menu to be used in data RelVals.

The new L1T menu tag replaces the previous L1Menu_Collisions2024_v1_2_0_xml. The difference wrt the previous tag is summarized here , and the new or removed seeds can be visible also via the Payload Inspector:
L1TDiff

The updated 2024 MC GTs in autoCond are the following:

And the difference wrt the GTs previously in autocond are the following:

Please notice that the new phase1_2024_realistic GT includes also three additional updates that were not yet propagated to autocond, and therefore pile-up here on top of the L1T menu change:

  • 140X_mcRun3_2024_realistic_v12:
    • Update GEM Channel mapping for 2024 MC conditions. See cmsTalk
  • 140X_mcRun3_2024_realistic_v13:
    • Update HLT PF hadron Calibration and JECs in preparation for Run3Summer24 campaign See details of the conditions in cmsTalk
  • 140X_mcRun3_2024_realistic_v14:
    • Update offline PF hadron calibration for 2024 MC i.e. Run3Summer24 campaign (See details in cmsTalk). The offline JECs derived with this PF HC should follow soon once they are ready

Validation

I verified that this PR does not conflict in github with #45387, therefore the two PRs can be kept and merged independently

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor Author

perrotta commented Jul 5, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45389/40840

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 5, 2024

A new Pull Request was created by @perrotta for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@consuegs, @perrotta, @saumyaphor4252 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @mmusich, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor Author

perrotta commented Jul 7, 2024

please test
(IBs not cleaned yet, but let see if at least we can collect some output)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c94767/40273/summary.html
COMMIT: 8532954
CMSSW: CMSSW_14_1_X_2024-07-07-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45389/40273/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 21 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2700 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 499
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246274
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: found differences in 6 / 45 workflows

@perrotta
Copy link
Contributor Author

perrotta commented Jul 8, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Jul 8, 2024

As expected, no effect on the outputs of the current workflows because of the modified L1 menu: the HLT menu that uses the new seeds is not yet included in those workflows

In the trigger results changes I see:

      Events    Accepted      Gained        Lost       Other  Trigger
         100           2         +18          -1           -  DST_PFScouting_AXOVLoose_v2
         100           1         +15           -           -  DST_PFScouting_AXOLoose_v2
         100           0         +15           -           -  DST_PFScouting_AXONominal_v4
         100           0         +14           -           -  DST_PFScouting_AXOTight_v4
         100           0          +6           -           -  DST_PFScouting_AXOVTight_v2
         100           0          +6           -           -  HLT_L1AXOVTight_v2

IIUC, this must come from the updated L1T menu. @caruta please confirm.

@caruta
Copy link
Contributor

caruta commented Jul 8, 2024

As expected, no effect on the outputs of the current workflows because of the modified L1 menu: the HLT menu that uses the new seeds is not yet included in those workflows

In the trigger results changes I see:

      Events    Accepted      Gained        Lost       Other  Trigger
         100           2         +18          -1           -  DST_PFScouting_AXOVLoose_v2
         100           1         +15           -           -  DST_PFScouting_AXOLoose_v2
         100           0         +15           -           -  DST_PFScouting_AXONominal_v4
         100           0         +14           -           -  DST_PFScouting_AXOTight_v4
         100           0          +6           -           -  DST_PFScouting_AXOVTight_v2
         100           0          +6           -           -  HLT_L1AXOVTight_v2

IIUC, this must come from the updated L1T menu. @caruta please confirm.

Hi @mmusich, indeed in the new L1T menu we have changed the NN model and thresholds for the AXO seeds, but we didn't change their name. So some differences in the HLT paths consuming these seeds (which are the ones shown here) are expected.

@perrotta
Copy link
Contributor Author

perrotta commented Jul 8, 2024

Thank you @mmusich for the check, and @caruta for confirming that the changes are the expected ones.
Indeed, I forgot the modifications applied to the existing seeds, that were all listed here (cited in the PR description)

Therefore "+1" from alca is confirmed

@antoniovilela
Copy link
Contributor

Thank you @mmusich for the check, and @caruta for confirming that the changes are the expected ones. Indeed, I forgot the modifications applied to the existing seeds, that were all listed here (cited in the PR description)

Therefore "+1" from alca is confirmed

Thanks.

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c5ab787 into cms-sw:master Jul 8, 2024
11 checks passed
@perrotta perrotta deleted the updateL1TmenuInGT branch July 9, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants