-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dEdx settings for HIN UPC MiniAOD #45363
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45363/40783
|
A new Pull Request was created by @stahlleiton for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 180, 180.1, 181, 181.1 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c85a/40189/summary.html
Comparison SummarySummary:
|
for pp NANO, I would hold on any development and changes until #36405. But since this is for HI, it's probably fine. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates the use of dEdx for HIN UPC MiniAOD production. It adds a DeDxEstimatorRekeyer module that change the keys of the dEdx estimator value maps and the dEdx hit info association to point to the packed candidates instead of the general tracks, so that they can be accessed in MiniAOD using packed candidate references. This module is activated only in the Run3 UPC era.
@mandrenguyen
PR validation:
Tested with relvals 180, 180.1, 181, 181.1
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: