Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dEdx settings for HIN UPC MiniAOD #45363

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

stahlleiton
Copy link
Contributor

PR description:

This PR updates the use of dEdx for HIN UPC MiniAOD production. It adds a DeDxEstimatorRekeyer module that change the keys of the dEdx estimator value maps and the dEdx hit info association to point to the packed candidates instead of the general tracks, so that they can be accessed in MiniAOD using packed candidate references. This module is activated only in the Run3 UPC era.

@mandrenguyen

PR validation:

Tested with relvals 180, 180.1, 181, 181.1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45363/40783

  • This PR adds an extra 24KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2024

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

  • PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Senphy, @ahinzmann, @andrzejnovak, @azotz, @castaned, @demuller, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @jdamgov, @jdolen, @mariadalfonso, @mbluj, @mmarionncern, @nhanvtran, @rappoccio, @schoef, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor

please test workflow 180, 180.1, 181, 181.1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6c85a/40189/summary.html
COMMIT: fddb79b
CMSSW: CMSSW_14_1_X_2024-07-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45363/40189/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 83 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3764146
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764123
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 51 files compared)
  • Checked 222 log files, 181 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@vlimant
Copy link
Contributor

vlimant commented Jul 3, 2024

for pp NANO, I would hold on any development and changes until #36405. But since this is for HI, it's probably fine.

@vlimant
Copy link
Contributor

vlimant commented Jul 3, 2024

+1

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 3, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ce21d39 into cms-sw:master Jul 4, 2024
11 checks passed
@stahlleiton stahlleiton deleted the DeDx_MiniAOD_CMSSW_14_1_X branch July 4, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants