Update of MTD validation: 4D vertices association with truth

[rdelliga]

PR description:

This PR updates the Primary4DVertexValidation class [1], in particular the matchReco2Sim function.
Matching between reco and sim vertices is performed based on a Private code from Wolfram Erdmann, which was ported on CMSSW with some issues that the present PR aims to handle. More details are given in the presentation [2].
The cut on MVA in matchReco2Sim [3], that select for RECO-SIM vertex matching only tracks with good time information, was moved in the use of time information to define weights. 
Furthermore, a bug was fixed in the one-to-one match at lines 1766 [4], where the indices of the reco vertices dominated via wos by that simulated vertex are stored with a push back of the index of the recovertex, which not only saves the simulated event corresponding to the wosmatch (i.e. the higher contribution to the wos), but also the lower ones that comes early in the loop, and this happens because saving information about wosmatch and pushing-back the wos_dominated_recv are done at the same time.
In this new version of the code, wos_dominated_recv is correctly filled outside simevent loop, after filling information about wosmatch.

PR validation:

The code was tested on the workflow
TTbar_PU_14TeV

[1]https://github.com/cms-sw/cmssw/blob/master/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc
[2]https://indico.cern.ch/event/1428838/contributions/6010350/attachments/2882474/5050701/MTD_DPG_June_DelliGatti.pdf
[3]https://github.com/cms-sw/cmssw/blob/master/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc#L1744
[4]https://github.com/cms-sw/cmssw/blob/master/Validation/MtdValidation/plugins/Primary4DVertexValidation.cc#L1766

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45343/40756

• This PR adds an extra 40KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Validation/MtdValidation/plugins/Primary4DVertexValidation.cc modified in PR(s): Sigmat0 and sigmat0Safe used to fix nonPID definition for good pions in MtdValidation  #45280

[cmsbuild]

A new Pull Request was created by @rdelliga for master.

It involves the following packages:

• Validation/MtdValidation (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @missirol this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6420ab/40160/summary.html
COMMIT: ec2c8da
CMSSW: CMSSW_14_1_X_2024-06-30-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45343/40160/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

• 29634.911

----- Begin Fatal Exception 01-Jul-2024 11:20:39 CEST-----------------------
An exception of category 'OutOfBound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLTriggerFinalPath'
   [2] Prefetching for module TriggerSummaryProducerAOD/'hltTriggerSummaryAOD'
   [3] Prefetching for module L1HPSPFTauProducer/'l1tHPSPFTauProducer'
   [4] Prefetching for module L1TPFCandMultiMerger/'l1tLayer1'
   [5] Prefetching for module L1TCorrelatorLayer1Producer/'l1tLayer1HGCal'
   [6] Prefetching for module PFClusterProducerFromHGC3DClusters/'l1tPFClustersFromHGC3DClusters'
   [7] Calling method for module HGCalBackendLayer2Producer/'l1tHGCalBackEndLayer2Producer'
Exception Message:
TC X1 = 2.10839e+07 out of the seeding histogram bounds 0.076 - 0.58
----- End Fatal Exception -------------------------------------------------

[fabiocos]

the failures seem unrelated to this PR

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6420ab/40173/summary.html
COMMIT: ec2c8da
CMSSW: CMSSW_14_1_X_2024-07-01-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45343/40173/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345088
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3345059
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4.902 KiB( 47 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 0.817 KiB MTD/Vertices
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[fabiocos]

@cms-sw/dqm-l2 any comment?

[tjavaid]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1