-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debugging capabilities to the CachingAllocator #45341
Add debugging capabilities to the CachingAllocator #45341
Conversation
Extend the CachingAllocator to optionally fill with a configurable value all memory blocks that are: allocated, cached for re-use, re-used, or deallocated. Extend the AlpakaService to configure the host and device CachingAllocators.
enable gpu |
please test |
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45341/40754
|
A new Pull Request was created by @fwyzard for master. It involves the following packages:
@fwyzard, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+heterogeneous Self-signed because @makortel is still away. I'm happy to address any comments and accept any suggestions to improve the system when he comes back. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
-1 Failed Tests: HeaderConsistency
Comparison SummarySummary:
GPU Comparison SummarySummary:
|
ignore tests-rejected with external-failure |
+1 |
merge |
PR description:
Extend the alpaka
CachingAllocator
to optionally fill with a configurable value all memory blocks that are: allocated, cached for re-use, re-used, or deallocated.Extend the AlpakaService to configure the host and device
CachingAllocator
s.Add a simple test to load the
AlpakaService
.To fill the NVIDIA GPU memory before every allocation or reuse with
0xA5
, you can now useTo fill the NVIDIA GPU memory before every deallocation or caching with
0x5A
, you can now useTo use different values and combination for allocations, deallocation, caching, and reuse, the full options are
To do the same for the pinned host memory used in the GPU transfers,
process.AlpakaServiceCudaAsync.hostAllocator
accepts the same options.To do the same for AMD GPUs, replace
AlpakaServiceCudaAsync
withAlpakaServiceROCmAsync
.To do the same for the CPU memory used by the alpaka modules running on the host, replace
AlpakaServiceCudaAsync
withAlpakaServiceSerialSync
.PR validation:
The new unit tests pass.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 14.0.x for data taking.