-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14_1_X] Rename MUODPG nano flatTable producers #45321
[14_1_X] Rename MUODPG nano flatTable producers #45321
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45321/40741
|
A new Pull Request was created by @battibass for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
enable nano |
very nice @battibass ; I do not expect any issue with this in master, please prepare the backport |
please abort |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fbd08/40110/summary.html
Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
@vlimant thanks a lot for the quick reaction, the backport is in #45334. In the end I did not keep the trigger stuff, do you think this is a problem? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The PR addresses a (second) issue observed when attempting the cantral production of the MUODPG nano custom flavour:
Configuration/DataProcessing/test/RunMerge.py
retains, out of collections fromNANOEDMAODoutput
, only the ones whose producer's name is of the form*Table
.The MUOPDG nano flavour sequence was adapted accordingly.
A small difference in the event content, too small to affect event-size significantly, is expected.
PR validation:
Tested using dedicated
runTheMatrix.py
workflows.Also, in 14_0_X, I tested that running the actual PdmV production workflow, followed by
Configuration/DataProcessing/test/RunMerge.py
, produces a properly-filled ntuple.PR backport:
This PR is intended to be backported to
CMSSW_14_0_X