Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_1_X] Rename MUODPG nano flatTable producers #45321

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

battibass
Copy link

PR description:

The PR addresses a (second) issue observed when attempting the cantral production of the MUODPG nano custom flavour:

Configuration/DataProcessing/test/RunMerge.py retains, out of collections from NANOEDMAODoutput, only the ones whose producer's name is of the form *Table.
The MUOPDG nano flavour sequence was adapted accordingly.

A small difference in the event content, too small to affect event-size significantly, is expected.

PR validation:

Tested using dedicated runTheMatrix.py workflows.
Also, in 14_0_X, I tested that running the actual PdmV production workflow, followed by Configuration/DataProcessing/test/RunMerge.py, produces a properly-filled ntuple.

PR backport:

This PR is intended to be backported to CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45321/40741

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass for master.

It involves the following packages:

  • DPGAnalysis/MuonTools (xpog)

@cmsbuild, @ftorrresd, @hqucms, @vlimant can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@battibass
Copy link
Author

please test

@vlimant
Copy link
Contributor

vlimant commented Jun 27, 2024

enable nano

@vlimant
Copy link
Contributor

vlimant commented Jun 27, 2024

very nice @battibass ; I do not expect any issue with this in master, please prepare the backport

@vlimant
Copy link
Contributor

vlimant commented Jun 27, 2024

please abort

@vlimant
Copy link
Contributor

vlimant commented Jun 27, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7fbd08/40110/summary.html
COMMIT: 4e96d0b
CMSSW: CMSSW_14_1_X_2024-06-26-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45321/40110/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246793
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246764
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 17023
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 17023
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 57 log files, 34 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.783 2.783 0.000 ( +0.0% ) 3.31 1.33 +149.3% 2.166 2.258
2500.001 2.897 2.897 0.000 ( +0.0% ) 2.95 1.24 +137.6% 2.510 2.284
2500.002 2.843 2.843 0.000 ( +0.0% ) 3.05 1.26 +141.4% 2.504 2.292
2500.01 1.446 1.446 0.000 ( +0.0% ) 5.62 2.89 +94.6% 2.273 2.356
2500.011 1.906 1.906 0.000 ( +0.0% ) 3.06 1.44 +112.7% 2.365 2.166
2500.012 1.761 1.761 0.000 ( +0.0% ) 4.43 2.09 +112.5% 2.338 2.184
2500.1 2.353 2.353 0.000 ( +0.0% ) 4.18 1.78 +134.9% 1.975 2.069
2500.2 2.459 2.459 0.000 ( +0.0% ) 4.80 2.04 +135.9% 1.985 1.952
2500.21 1.285 1.285 0.000 ( +0.0% ) 3.06 1.53 +100.0% 2.178 1.977
2500.211 1.668 1.668 0.000 ( +0.0% ) 2.88 1.98 +45.3% 2.210 2.073
2500.3 2.229 2.229 0.000 ( +0.0% ) 8.83 3.96 +123.2% 1.968 1.983
2500.301 2.833 2.833 0.000 ( +0.0% ) 8.12 6.20 +31.0% 1.839 1.970
2500.31 7.164 7.164 0.000 ( +0.0% ) 1.50 1.10 +36.9% 1.713 1.707
2500.311 1.568 1.568 0.000 ( +0.0% ) 8.71 6.84 +27.2% 1.059 1.049
2500.312 540.338 540.338 0.000 ( +0.0% ) 0.54 0.35 +51.2% 1.661 1.670
2500.313 816.269 816.269 0.000 ( +0.0% ) 0.76 0.60 +25.8% 1.645 1.644
2500.32 1.348 1.348 0.000 ( +0.0% ) 10.50 5.66 +85.4% 2.330 2.384
2500.321 1.757 1.757 0.000 ( +0.0% ) 8.89 5.80 +53.4% 2.413 2.462
2500.322 1.236 1.236 0.000 ( +0.0% ) 9.02 6.45 +39.8% 2.216 2.284
2500.323 7.642 7.642 0.000 ( +0.0% ) 4.11 2.99 +37.4% 1.924 1.946
2500.324 1.874 1.874 0.000 ( +0.0% ) 8.86 7.06 +25.4% 2.189 2.369
2500.325 4.136 4.136 0.000 ( +0.0% ) 4.06 2.64 +54.0% 1.820 1.988
2500.326 3.342 3.342 0.000 ( +0.0% ) 1.47 0.84 +75.1% 1.757 2.017
2500.327 1.811 1.811 0.000 ( +0.0% ) 8.91 7.03 +26.8% 1.997 2.367
2500.328 3.364 3.364 0.000 ( +0.0% ) 1.29 0.81 +59.1% 2.146 2.041
2500.4 2.374 2.374 0.000 ( +0.0% ) 8.18 3.74 +118.8% 1.804 1.928
2500.401 1.891 1.891 0.000 ( +0.0% ) 7.90 5.26 +50.2% 1.772 1.858
2500.402 2.950 2.950 0.000 ( +0.0% ) 7.62 5.46 +39.6% 1.760 1.922
2500.403 8.700 8.700 0.000 ( +0.0% ) 2.82 1.46 +93.2% 1.781 1.929
2500.404 5.474 5.474 0.000 ( +0.0% ) 1.08 0.58 +84.7% 1.806 1.978
2500.405 2.860 2.860 0.000 ( +0.0% ) 7.73 5.11 +51.3% 1.895 1.919
2500.406 5.491 5.491 0.000 ( +0.0% ) 1.02 0.50 +103.7% 1.846 2.004
2500.5 5.194 5.194 0.000 ( +0.0% ) 15.96 10.30 +54.9% 1.439 1.527
2500.51 9.120 9.120 0.000 ( +0.0% ) 9.61 5.77 +66.5% 1.473 1.475

@battibass
Copy link
Author

very nice @battibass ; I do not expect any issue with this in master, please prepare the backport

@vlimant thanks a lot for the quick reaction, the backport is in #45334.

In the end I did not keep the trigger stuff, do you think this is a problem?

@vlimant
Copy link
Contributor

vlimant commented Jun 28, 2024

+1
no problem

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b9adcb6 into cms-sw:master Jul 1, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants