-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTPPS validation: workaround for -O3 ASAN compilation issue #45304
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40711
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45304/40712
|
A new Pull Request was created by @dan131riley for master. It involves the following packages:
@antoniovagnerini, @syuvivida, @nothingface0, @rvenditti, @tjavaid, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: UnitTests RelVals RelVals-INPUT AddOn Unit TestsI found 4 errors in the following unit tests: ---> test test_MC_23_setup had ERRORS ---> test test_MC_23_crosscheck had ERRORS ---> test test_MC_22_crosscheck had ERRORS and more ... RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...
AddOn Tests
Expand to see more addon errors ...
|
@tjavaid , IBs are broken, lets wait for today's 11h00 IB |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3146a/40140/summary.html
Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
please test for CMSSW_14_1_ASAN_X |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f3146a/40248/summary.html |
+1 |
PR description:
With
-O3
optimization in the ASAN builds,Validation/CTPPS/plugins/ValidationCTPPSPlugins/CTPPSTrackDistributionPlotter.cc
is failing to compile with errors of the form:For various reasons detailed in #44931 (comment) this has to be a compiler bug. Nevertheless, this PR provides a workaround for the compilation errors.
PR validation:
Compiles, purely technical fix, harmless.