-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0.X] Adding general DQM modules for pixel tracks #45302
Conversation
A new Pull Request was created by @borzari for CMSSW_14_0_X. It involves the following packages:
@syuvivida, @Martin-Grunewald, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild, @rvenditti, @mandrenguyen, @fwyzard, @makortel, @jfernan2, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
+heterogeneous |
Pull request #45302 was updated. @jfernan2, @tjavaid, @fwyzard, @antoniovagnerini, @cmsbuild, @mandrenguyen, @rvenditti, @mmusich, @makortel, @syuvivida, @nothingface0, @Martin-Grunewald can you please check and sign again. |
+heterogeneous |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e13bb/40071/summary.html Comparison SummarySummary:
|
+hlt
|
+1
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
urgent
|
+1 |
Backport of #45206
PR description:
This PR is the replacement of #43964 with essentially the same changes, except for the Alpaka vs CUDA compare modules that are not needed anymore. It still includes generalized DQM compare modules for pixel rechits, tracks and vertices, which are templated if needed for other SoA types, an HLT customize function to include the module changes and pixel digi errors monitoring (that is also included in the DQM step), and the changes requested in #43964 (comment).
PR validation:
Executed the code with wf
12834.403
to check DQM plots and everything works as expected.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This is a backport of #45206 to CMSSW_14_0_X.
Pinging @mmusich @makortel @fwyzard @AdrianoDee