Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0.X] Adding general DQM modules for pixel tracks #45302

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

borzari
Copy link
Contributor

@borzari borzari commented Jun 25, 2024

Backport of #45206

PR description:

This PR is the replacement of #43964 with essentially the same changes, except for the Alpaka vs CUDA compare modules that are not needed anymore. It still includes generalized DQM compare modules for pixel rechits, tracks and vertices, which are templated if needed for other SoA types, an HLT customize function to include the module changes and pixel digi errors monitoring (that is also included in the DQM step), and the changes requested in #43964 (comment).

PR validation:

Executed the code with wf 12834.403 to check DQM plots and everything works as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #45206 to CMSSW_14_0_X.

Pinging @mmusich @makortel @fwyzard @AdrianoDee

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

A new Pull Request was created by @borzari for CMSSW_14_0_X.

It involves the following packages:

  • DQM/SiPixelHeterogeneous (dqm)
  • DataFormats/TrackSoA (heterogeneous, reconstruction)
  • DataFormats/TrackingRecHitSoA (heterogeneous, reconstruction)
  • EventFilter/SiPixelRawToDigi (reconstruction)
  • HLTrigger/Configuration (hlt)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)

@syuvivida, @Martin-Grunewald, @antoniovagnerini, @tjavaid, @nothingface0, @cmsbuild, @rvenditti, @mandrenguyen, @fwyzard, @makortel, @jfernan2, @mmusich can you please review it and eventually sign? Thanks.
@missirol, @VinInn, @threus, @ferencek, @fioriNTU, @silviodonato, @gpetruc, @mmusich, @felicepantaleo, @rovere, @mroguljic, @tsusa, @jandrea, @JanFSchulte, @dkotlins, @idebruyn, @mtosi, @Martin-Grunewald, @VourMa, @tvami, @GiacomoSguazzoni this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

Pull request #45302 was updated. @jfernan2, @tjavaid, @fwyzard, @antoniovagnerini, @cmsbuild, @mandrenguyen, @rvenditti, @mmusich, @makortel, @syuvivida, @nothingface0, @Martin-Grunewald can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

+heterogeneous

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e13bb/40071/summary.html
COMMIT: 3506446
CMSSW: CMSSW_14_0_X_2024-06-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45302/40071/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mmusich
Copy link
Contributor

mmusich commented Jun 25, 2024

+hlt

@tjavaid
Copy link

tjavaid commented Jun 26, 2024

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mmusich
Copy link
Contributor

mmusich commented Jul 2, 2024

urgent

  • please @cms-sw/orp-l2 include this in the next CMSSW_14_0_X release

@cmsbuild cmsbuild added the urgent label Jul 2, 2024
@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants