Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0] Backport of #45151 (HIon type def for pixel alpaka) #45299

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

vince502
Copy link

This is a backport of PR cmssw-45151 onto CMSSW_14_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

A new Pull Request was created by @vince502 for CMSSW_14_0_X.

It involves the following packages:

  • DataFormats/TrackSoA (heterogeneous, reconstruction)
  • RecoLocalTracker/SiPixelClusterizer (reconstruction)
  • RecoLocalTracker/SiPixelRecHits (reconstruction)
  • RecoTracker/Configuration (reconstruction)
  • RecoTracker/PixelSeeding (reconstruction)
  • RecoTracker/PixelTrackFitting (reconstruction)

@makortel, @fwyzard, @cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@gpetruc, @missirol, @VourMa, @felicepantaleo, @tsusa, @ferencek, @mmusich, @dkotlins, @JanFSchulte, @rovere, @mroguljic, @threus, @GiacomoSguazzoni, @mtosi, @tvami, @dgulhan, @VinInn this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

please test

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

backport #45151

@fwyzard
Copy link
Contributor

fwyzard commented Jun 25, 2024

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe9678/40065/summary.html
COMMIT: cac75ef
CMSSW: CMSSW_14_0_X_2024-06-24-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45299/40065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39744
  • DQMHistoTests: Total failures: 166
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 39578
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 23c4792 into cms-sw:CMSSW_14_0_X Jul 2, 2024
13 checks passed
@vince502 vince502 deleted the backport_45151 branch July 3, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants