Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Protect against null VertexRef in deep_helpers.cc #45297

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

mandrenguyen
Copy link
Contributor

backport of #45296

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

A new Pull Request was created by @mandrenguyen for CMSSW_14_0_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)

@jfernan2, @mandrenguyen, @cmsbuild can you please review it and eventually sign? Thanks.
@Ming-Yan, @hqucms, @andrzejnovak, @Senphy, @castaned, @missirol, @AlexDeMoor, @demuller this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 25, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor Author

type btv

@mandrenguyen
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6cc8d0/40054/summary.html
COMMIT: 62f7732
CMSSW: CMSSW_14_0_X_2024-06-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45297/40054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor Author

urgent
At joint ops the ORM shifter (David Lange) suggested that this PR could be patch-compatible. Otherwise, it might be a while before this is included in the release.
We could discuss this at the Offline Release Planning meeting tomorrow.

@cmsbuild cmsbuild added the urgent label Jul 1, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 45ba902 into cms-sw:CMSSW_14_0_X Jul 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants