Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0] Add Unpacker for L1T Calo Layer 1 to unpack CICADA #45294

Closed

Conversation

aloeliger
Copy link
Contributor

PR description:

backport of #45037

Description of original:

This PR adds an unpacker to the L1T Calo Layer 1 Unpacking Setup to explicitly unpack CICADA (found in FED 1356, AMC slot 7). This PR relies on data-types introduced in it's companion PR #44222. #44222 Unpacks the uGT received CICADA scores, while this PR unpacks the Calo sent CICADA scores.

This PR is being backported with #45293 to keep all unpacker tools developed available

PR validation:

Code has been validated in the original production release

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This code is a backport to CMSSW_14_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

A new Pull Request was created by @aloeliger for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@thomreis, @Martin-Grunewald, @eyigitba, @mmusich, @missirol, @dinyar this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2024

cms-bot internal usage

@aloeliger
Copy link
Contributor Author

backport of #45037

@aloeliger
Copy link
Contributor Author

test parameters:

@aloeliger
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98e6c5/40051/summary.html
COMMIT: a8b2393
CMSSW: CMSSW_14_0_X_2024-06-24-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45294/40051/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 83 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 61 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 1202
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3341236
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor Author

This is being closed in favor of packaging all commits together with #45293 to mirror changes made to #44222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants