Algo not found warning removed from L1TStag2uGTTiming module for the …

[jaisatul]

PR description:

In response to comments on #45242

• Algo not found warning messages removed from the L1TStage2uGTTiming for lookup in Unprescaled/Prescaled algo short list

PR validation:

Tested locally with 2023/2024 streamer files

[cmsbuild]

cms-bot internal usage

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45290/40690

• This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45290/40690/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45290/40690/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[mmusich]

@jaisatul can you apply the code-formatting patch as requested by the bot: #45290 (comment).

[eyigitba]

@jaisatul @mmusich , should we actually keep these messages as LogDebug instead of removing them completely?

[mmusich]

should we actually keep these messages as LogDebug instead of removing them completely?

that's not my call. LogDebug is akin to not having them as far as production is concerned.

[eyigitba]

Exactly. I was thinking this would remove the flood of messages and also keep the functionality in case we need to debug something later on. @jaisatul , then I suggest you move these to LogDebug instead of removing them

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45290/40761

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @jaisatul for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@missirol, @mmusich this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[jaisatul]

@eyigitba @mmusich I have fixed the code formatting and have replaced the LogWarning with LogDebug meesages and have tested it locally. Please review.

[tjavaid]

please test

[cmsbuild]

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9a11e/40674/summary.html
COMMIT: 5eb26e6
CMSSW: CMSSW_14_1_X_2024-07-28-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45290/40674/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 31 lines from the logs
• Reco comparison results: 137 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3423961
• DQMHistoTests: Total failures: 2476
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3421465
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 196 log files, 165 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[jaisatul]

@tjavaid ,
Hi, I already tested the changes locally. Do I need to make some specific tests?

[tjavaid]

please test

• triggering for fresh output

[mmusich]

I think that when #45242 is merged, this PR has no reason to be merged.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9a11e/41045/summary.html
COMMIT: 5eb26e6
CMSSW: CMSSW_14_1_X_2024-08-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45290/41045/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 2024.4080052024.408005_RunParkingDoubleMuonLowMass02024F_50k/step1_dasquery.log
• 2024.10412024.1041_RunJetMET02024C_1M/step1_dasquery.log
• 2024.110052024.11005_RunParkingLLP2024C_500k/step1_dasquery.log

Expand to see more relval errors ...

• 2024.408005
• 2024.1041
• 2024.11005

Comparison Summary

Summary:

• You potentially removed 34 lines from the logs
• Reco comparison results: 130 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3324622
• DQMHistoTests: Total failures: 4610
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3319992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[cmsbuild]

Milestone for this pull request has been moved to CMSSW_14_2_X. Please open a backport if it should also go in to CMSSW_14_1_X.

[eyigitba]

I think we can close this PR since it's not necessary after the recently merged PRs

[tjavaid]

I think we can close this PR since it's not necessary after the recently merged PRs

@jaisatul ping.