Remove Passthrough Pattern Recognition from TICLv4

[waredjeb]

This PR removes the PassThrough pattern recognition (developed for TICLv5) that was incorrectly introduced in TICLv4.

No changes are expected in physics since the additional collection was not used anywhere else in the TICL workflow.

Should be tested with any *.203 workflow (e.g. 29696.203 and 29896.203 )

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45272/40660

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoHGCal/TICL/python/iterativeTICL_cff.py modified in PR(s): Camiielle/debug post rebase branch #45226

[cmsbuild]

A new Pull Request was created by @waredjeb for master.

It involves the following packages:

• RecoHGCal/TICL (upgrade, reconstruction)

@cmsbuild, @srimanob, @jfernan2, @mandrenguyen, @subirsarkar can you please review it and eventually sign? Thanks.
@lecriste, @rovere, @missirol, @forthommel, @apsallid, @sobhatta, @hatakeyamak, @sameasy, @youyingli, @felicepantaleo this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mandrenguyen]

please test workflow 29696.203, 29896.203

[waredjeb]

please test workflow 29696.203, 29896.203

Hi @mandrenguyen thanks for the tests! These two workflows are for Phase-2, don't we need the options -w upgrade ?
I think we had a problem in a previous PR without setting -w upgrade

[felicepantaleo]

@cmsbuild please abort

[felicepantaleo]

test parameters:

• workflow_opts= -w upgrade
• workflow = 29696.203,29896.203

[felicepantaleo]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2229/39997/summary.html
COMMIT: 6f652f8
CMSSW: CMSSW_14_1_X_2024-06-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45272/39997/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344992
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
No changes expected or observed

[waredjeb]

So, I am not sure what happended, DAS says that workflows *203 have failed, and I don't see the comparison with the baseline. But looking at the runMatrix output looks like the workflows ran correctly:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2229/39997/runTheMatrix-results/29696.203_CloseByPGun_CE_E_Front_120um+2026D110_ticl_v5/
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4e2229/39997/runTheMatrix-results/29896.203_CloseByPGun_CE_E_Front_120um+2026D110PU_ticl_v5/

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[waredjeb]

Hi! @antoniovilela it would be nice if this could be merged before pre5 is built!
Thank you!

[rappoccio]

+1