Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extended version of SCraw energy plots [14_0_X] #45267

Merged

Conversation

kyungminparkdrums
Copy link

PR description:

This PR adds a plot in ECAL DQM, "SC Raw Energy (high scale)". This is a copy of an existing plot "SC Raw Energy" but with x-range extended to 1 TeV.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the backport to 14_0_X, which is used in production at the moment. Master PR is #45266

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2024

A new Pull Request was created by @kyungminparkdrums for CMSSW_14_0_X.

It involves the following packages:

  • DQM/EcalMonitorTasks (dqm)

@tjavaid, @nothingface0, @cmsbuild, @rvenditti, @antoniovagnerini, @syuvivida can you please review it and eventually sign? Thanks.
@ReyerBand, @rchatter, @wang0jin, @argiro, @thomreis this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 19, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Jun 19, 2024

backport of #45266

@tjavaid
Copy link

tjavaid commented Jun 19, 2024

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24bea8/39968/summary.html
COMMIT: c924226
CMSSW: CMSSW_14_0_X_2024-06-19-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45267/39968/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 103 lines to the logs
  • Reco comparison results: 40 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3342458
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3342435
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 18.13000000000001 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 0.259 KiB EcalBarrel/EBClusterTask
  • DQMHistoSizes: changed ( 1000.0,... ): 0.259 KiB EcalEndcap/EEClusterTask
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@kyungminparkdrums kyungminparkdrums changed the title Add extended version of SCraw energy plots Add extended version of SCraw energy plots [14_0_X] Jun 20, 2024
@tjavaid
Copy link

tjavaid commented Jun 21, 2024

+1

  • P5 tests OK.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@thomreis
Copy link
Contributor

type ecal

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 61dacc5 into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants