-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DAQ) fix double conting of meta event (14_0_X backport) #45254
Conversation
A new Pull Request was created by @smorovic for CMSSW_14_0_X. It involves the following packages:
@smorovic, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
@cmsbuild please test |
urgent |
+daq |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-67a8f0/39943/summary.html Comparison SummarySummary:
|
+1 |
PR description:
No counting of meta events in JSON file output count.
Important because it can affect number of accepted events entered in SM database
PR validation:
Running the unit test by hand checked that problem is fixed (number of events in dat file matches number of events in jsn file, which is not the case without this fix).
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #45253
Reason: fix event accounting problem in HLT (urgent)