Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed artificial new files in StreamerInputModule [14_0] #45246

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Jun 18, 2024

PR description:

The genuineCloseFile was incorrectly resetting the member which tracked if this is an artificial file boundary.
This should fix a problem seen in the ECal online calibration.

PR validation:

I ran the test given in a private email and the file is now processed without hitting an assert.

backport of #45247

The genuineCloseFile was incorrectly resetting the member which
tracked if this is an artificial file boundary.
@Dr15Jones Dr15Jones changed the title Fixed artificial new files in StreamerInputModule Fixed artificial new files in StreamerInputModule [14_0] Jun 18, 2024
@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jun 18, 2024
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones for CMSSW_14_0_X.

It involves the following packages:

  • IOPool/Streamer (core)

@makortel, @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit, @makortel this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 18, 2024

cms-bot internal usage

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e886/39929/summary.html
COMMIT: e013832
CMSSW: CMSSW_14_0_X_2024-06-17-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45246/39929/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fwyzard
Copy link
Contributor

fwyzard commented Jun 18, 2024

urgent

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 90d6c7b into cms-sw:CMSSW_14_0_X Jun 24, 2024
10 checks passed
@Dr15Jones Dr15Jones deleted the fixStreamerInputModule_14_0 branch July 17, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants