-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed artificial new files in StreamerInputModule [14_0] #45246
Fixed artificial new files in StreamerInputModule [14_0] #45246
Conversation
The genuineCloseFile was incorrectly resetting the member which tracked if this is an artificial file boundary.
A new Pull Request was created by @Dr15Jones for CMSSW_14_0_X. It involves the following packages:
@makortel, @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
cms-bot internal usage |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e8e886/39929/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
urgent |
+1 |
PR description:
The genuineCloseFile was incorrectly resetting the member which tracked if this is an artificial file boundary.
This should fix a problem seen in the ECal online calibration.
PR validation:
I ran the test given in a private email and the file is now processed without hitting an assert.
backport of #45247