Protect against null VertexRef in DeepBoostedJetTagInfoProducer.cc

[mandrenguyen]

Avoids an invalid reference exception discussed here:
#45190

The issue only pops up on AMD for a reason that's not clear to me.
I have admittedly not investigated why the VertexRef is null.

[cmsbuild]

cms-bot internal usage

[mandrenguyen]

Incidentally, is PR testing done on Intel or AMD?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45245/40626

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mandrenguyen for master.

It involves the following packages:

• RecoBTag/FeatureTools (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@castaned, @Ming-Yan, @hqucms, @demuller, @Senphy, @andrzejnovak, @missirol, @AlexDeMoor this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45245/40627

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #45245 was updated. @cmsbuild, @mandrenguyen, @jfernan2 can you please check and sign again.

[mandrenguyen]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4afc5f/39945/summary.html
COMMIT: 18d6a7a
CMSSW: CMSSW_14_1_X_2024-06-18-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45245/39945/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 658 lines to the logs
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 70
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344928
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[VinInn]

Null vertex ref are normal (if pfCand has no track associated )
I suggest to change the protections as

diff --git a/RecoBTag/FeatureTools/src/deep_helpers.cc b/RecoBTag/FeatureTools/src/deep_helpers.cc
index 76b443542b3..faf1649d9b8 100644
--- a/RecoBTag/FeatureTools/src/deep_helpers.cc
+++ b/RecoBTag/FeatureTools/src/deep_helpers.cc
@@ -150,7 +150,7 @@ namespace btagbtvdeep {

   float vtx_ass_from_pfcand(const reco::PFCandidate &pfcand, int pv_ass_quality, const reco::VertexRef &pv) {
     float vtx_ass = pat::PackedCandidate::PVAssociationQuality(qualityMap[pv_ass_quality]);
-    if (pfcand.trackRef().isNonnull() && pv->trackWeight(pfcand.trackRef()) > 0.5 && pv_ass_quality == 7) {
+    if (pv.isNonnull() && pfcand.trackRef().isNonnull() && pv->trackWeight(pfcand.trackRef()) > 0.5 && pv_ass_quality == 7) {
       vtx_ass = pat::PackedCandidate::UsedInFitTight;
     }
     return vtx_ass;

the check pfcand.trackRef().isNonnull() is most probably not required and my guess is that was there to protect against no pv ass

[VinInn]

IN anycase this PR cure the symptom NOT the cause!!!

[mandrenguyen]

hold

[cmsbuild]

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mandrenguyen]

IN anycase this PR cure the symptom NOT the cause!!!

Indeed this was clear. Thanks for the proposed solution, I will update the PR with your suggestion and test it, when I find a free moment (offline F2F meeting happening now)

[mandrenguyen]

@VinInn If you prefer, feel free to open a new PR of course.