Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking MC truth: fixes and updates to TrackingTruthDumper #45244

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Jun 17, 2024

PR description:

Minor updates and a fix to the TrackingTruthDumper test class, used to inspect the TrackingParticle and TrackingVertex content of an event.

PR validation:

The code produces the desired output, e.g.:


 SimVertex / SimTrack structure dump 

 SimVertex in the event = 2
 SimTracks in the event = 3


TrackingVertex 0 = Vertex Position & Event #(-0.000750633,-0.000621845,-3.41805,-2.34691e-10) 0.0
 Associated with 1 tracks
 HepMC vertex position -0.00750633,-0.00621845-34.1805
 Geant vertex position (-0.000750633,-0.000621845,-3.41805,-2.34691e-10)
 Daughter starts:      (-0.000750633,-0.000621845,-3.41805) p (-3.31013,-9.42794,-26.7694,28.5735)


TPs of this vertex: 

TrackingParticle 0 isMerged 0
TP momentum, q, ID, & Event #: (-3.31013,-9.42794,-26.7694,28.5735) 0 22 0.0
 HepMC Track Momentum 9.99215
 Geant Track Momentum  (-3.31013,-9.42794,-26.7694,28.5735)
 Geant Track ID & type 1 22
 TP Vertex (-0.000750633,-0.000621845,-3.41805)
 Source vertex: (-0.000750633,-0.000621845,-3.41805,-2.34691e-10)
 1 Decay vertices
 Decay vertices:      (-39.665,-112.973,-324.187,1.11861e-08)




TrackingVertex 1 = Vertex Position & Event #(-39.665,-112.973,-324.187,1.11861e-08) 0.0
 Associated with 2 tracks
 Geant vertex position (-39.665,-112.973,-324.187,1.11861e-08)
 Daughter starts:      (-39.665,-112.973,-324.187) p (-2.89235,-8.23948,-23.3964,24.9729)
 Daughter starts:      (-39.665,-112.973,-324.187) p (-0.417962,-1.18858,-3.37293,3.60056)
 Source   starts: (-0.000750633,-0.000621845,-3.41805), p (-3.31013,-9.42794,-26.7694,28.5735)


TPs of this vertex: 

TrackingParticle 0 isMerged 0
TP momentum, q, ID, & Event #: (-2.89235,-8.23948,-23.3964,24.9729) -1 11 0.0
 Geant Track Momentum  (-2.89235,-8.23948,-23.3964,24.9729)
 Geant Track ID & type 2 11
 TP Vertex (-39.665,-112.973,-324.187)
 Source vertex: (-39.665,-112.973,-324.187,1.11861e-08)
 0 Decay vertices


TrackingParticle 1 isMerged 0
TP momentum, q, ID, & Event #: (-0.417962,-1.18858,-3.37293,3.60056) 1 -11 0.0
 Geant Track Momentum  (-0.417962,-1.18858,-3.37293,3.60056)
 Geant Track ID & type 3 -11
 TP Vertex (-39.665,-112.973,-324.187)
 Source vertex: (-39.665,-112.973,-324.187,1.11861e-08)
 0 Decay vertices




TrackingParticles: 

TrackingParticle 0 isMerged 0
TP momentum, q, ID, & Event #: (-3.31013,-9.42794,-26.7694,28.5735) 0 22 0.0
 HepMC Track Momentum 9.99215
 Geant Track Momentum  (-3.31013,-9.42794,-26.7694,28.5735)
 Geant Track ID & type 1 22
 TP Vertex (-0.000750633,-0.000621845,-3.41805)
 Source vertex: (-0.000750633,-0.000621845,-3.41805,-2.34691e-10)
 1 Decay vertices
 Decay vertices:      (-39.665,-112.973,-324.187,1.11861e-08)

(...)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45244/40623

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos for master.

It involves the following packages:

  • SimGeneral/TrackingAnalysis (simulation)

@cmsbuild, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@dgulhan, @CeliaFernandez, @abbiendi, @GiacomoSguazzoni, @VourMa, @jhgoh, @VinInn, @Fedespring, @mmusich, @trocino, @cericeci, @HuguesBrun, @andrea21z, @mtosi, @slomeo, @rovere, @JanFSchulte this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0265a/39925/summary.html
COMMIT: 56d3f62
CMSSW: CMSSW_14_1_X_2024-06-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45244/39925/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3451538
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3451518
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 170 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor Author

@cms-sw/simulation-l2 @cms-sw/tracking-pog-l2 comments?

@civanch
Copy link
Contributor

civanch commented Jun 20, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor

slava77 commented Jun 20, 2024

@cms-sw/tracking-pog-l2 comments?

looks OK.
Thank you for fixing the vtx vs trk size swap

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0f42389 into cms-sw:master Jun 21, 2024
11 checks passed
@fabiocos fabiocos deleted the fc-fixTP20240617 branch October 21, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants