Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unprescaled AXO seeds (L1_AXO_Nominal, L1_AXO_VTight) added to the un… #45242

Merged
merged 3 commits into from
Aug 27, 2024
+56 −35
Merged

Unprescaled AXO seeds (L1_AXO_Nominal, L1_AXO_VTight) added to the un… #45242

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6fdd92
Unprescaled AXO seeds (L1_AXO_Nominal, L1_AXO_VTight) added to the un…
jaisatul Jun 17, 2024
4a48dde
AXO and CICADA seeds added with 2024 era modifier
jaisatul Aug 5, 2024
5aebe51
Update DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py
jaisatul Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DQM/L1TMonitor/python/L1TStage2uGTTiming_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@
"L1_SingleJet180",
"L1_ETMHF130",
"L1_HTT360er",
"L1_ETT2000"
"L1_ETT2000",
"L1_AXO_Nominal",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about the other years before 2024?
Will we be flooded by more warning message? see #43488

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These seeds have been added in 2024 Menu. I tested with 2023 Runs and I get the warning that the Algo not found in the Trigger Menu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precisely. What does the L1T DPG plan to do about these additional warnings?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mmusich , I think the easiest way for this would be if we had year based eras in Run 3. In the meanwhile I think modifying the code to remove this warning message is ok. Atul said that the plots already omit the non-existing seeds, so there might be no reason to keep this warning in place. We'll have a look and provide a fix for these messages soon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eyigitba

I think the easiest way for this would be if we had year based eras in Run 3.

now we do, see please #43761.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich , thanks! I wasn't aware of this. We should definitely add this to the config, but in the meanwhile we can still suppress the warning message if we added one of these seeds in the middle of a year.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaisatul , @eyigitba ping.

"L1_AXO_VTight"
),
prescaledAlgoShortList = cms.untracked.vstring(
"L1_FirstCollisionInTrain",
Expand Down