workaround for -O3 compilation issues in Geometry/HGCalCommonData

[dan131riley]

PR description:

This PR has a workaround for the compiler errors seen with '-O3' optimization covered in #44931 (comment). This is likely a compiler bug, but I'm not optimistic about getting a simple replication for a gcc bug report.

PR validation:

Compiles, purely technical fix.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45219/40581

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @dan131riley for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @bsunanda, @subirsarkar, @cmsbuild, @makortel, @srimanob, @Dr15Jones, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @bsunanda this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-541921/39881/summary.html
COMMIT: 3578142
CMSSW: CMSSW_14_1_X_2024-06-13-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45219/39881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 854
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344144
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

thanks @dan131riley , can you please revert #45201 change in this PR ( you might have to rebase as #45201 was merge last night)?

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45219/40595

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #45219 was updated. @mdhildreth, @srimanob, @cmsbuild, @subirsarkar, @Dr15Jones, @makortel, @bsunanda, @civanch can you please check and sign again.

[Dr15Jones]

@dan131riley Thanks!

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-541921/39895/summary.html
COMMIT: fb592a1
CMSSW: CMSSW_14_1_X_2024-06-14-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45219/39895/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 1 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3345018
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3344995
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1