-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflow runner: use previous step output as next step input #45214
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45214/40567
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@miquork, @subirsarkar, @srimanob, @cmsbuild, @AdrianoDee, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 105.0 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa443f/39867/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please review this? This should fix the failing 105.0 workflow in IBs |
+pdmv @smuzaffar thanks for handling this and sorry for the delay. |
@cms-sw/upgrade-l2 gentle ping |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 , can you please review this? Thsi should fix the failing 105.0 workflow in IBs |
ping @cms-sw/orp-l2 |
+1 |
Looks like change in https://github.com/cms-sw/cmssw/pull/45005/files has broken workflow [105.0] (https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_1_X_2024-06-12-1900/pyRelValMatrixLogs/run/105.0_MinBiasHcalNZS/step3_MinBiasHcalNZS.log#/) . This happens when
recoOutput
is not set. This proposes to use the previous setup output as input ifrecoOutput
is not set (which was what we were doing before #45005 change)FYI @AdrianoDee , I do not know if this is the correct fix, may be for 105.0 the
recoOutput
should be set? Feel free to provide a correct fix[a]