Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow runner: use previous step output as next step input #45214

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Jun 13, 2024

Looks like change in https://github.com/cms-sw/cmssw/pull/45005/files has broken workflow [105.0] (https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el8_amd64_gcc12/CMSSW_14_1_X_2024-06-12-1900/pyRelValMatrixLogs/run/105.0_MinBiasHcalNZS/step3_MinBiasHcalNZS.log#/) . This happens when recoOutput is not set. This proposes to use the previous setup output as input if recoOutput is not set (which was what we were doing before #45005 change)

FYI @AdrianoDee , I do not know if this is the correct fix, may be for 105.0 the recoOutput should be set? Feel free to provide a correct fix

[a]

usage: cmsDriver.py <TYPE> [options].
Example:

cmsDriver.py reco -s RAW2DIGI,RECO --conditions STARTUP_V4::All --eventcontent RECOSIM
cmsDriver.py: error: argument --filein: expected one argument

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 13, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45214/40567

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@miquork, @subirsarkar, @srimanob, @cmsbuild, @AdrianoDee, @sunilUIET can you please review it and eventually sign? Thanks.
@fabiocos, @slomeo, @Martin-Grunewald, @missirol, @makortel this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test workflow 105.0

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa443f/39867/summary.html
COMMIT: 4545c62
CMSSW: CMSSW_14_1_X_2024-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45214/39867/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
105.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 21 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3345018
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344995
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 205 log files, 167 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 can you please review this? This should fix the failing 105.0 workflow in IBs

@AdrianoDee
Copy link
Contributor

+pdmv

@smuzaffar thanks for handling this and sorry for the delay.

@iarspider
Copy link
Contributor

@cms-sw/upgrade-l2 gentle ping

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , can you please review this? Thsi should fix the failing 105.0 workflow in IBs

@smuzaffar
Copy link
Contributor Author

ping @cms-sw/orp-l2

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b20c7aa into cms-sw:master Jul 1, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants