Introduce reco::Track::recHitsOk() and use it to remove try/catch pattern in SingleLongTrackProducer

[mmusich]

PR description:

This PR addresses this #45162 (comment), by introducing a new helper method reco::Track::recHitsOk() to check the rechits availability content of the input tracks in the track selection logic of SingleLongTrackProducer.
This allows to remove a try/catch pattern in it, causing lots of extraneous exceptions being thrown (and caught) in prompt reco jobs, as reported initially in the issue #45162. The implementation (from @borzari) follows the suggestion here #45162 (comment).
I profit of this PR to refactor the track selection in SingleLongTrackProducer to avoid filling the selTracks with tracks without reco::Track::Extra attached to them.

PR validation:

I could run this test:

cmssw/DQM/TrackingMonitorSource/test/BuildFile.xml

Line 2 in 4639c10

<test name="testTrackingResolution" command="testTrackingResolution.sh"/>

(even using the whole input file) without crashes.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, will be backported to CMSSW_14_0_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45213/40565

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich for master.

It involves the following packages:

• DataFormats/TrackReco (reconstruction)
• RecoTracker/FinalTrackSelectors (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @mtosi, @dgulhan, @JanFSchulte, @VourMa, @missirol, @felicepantaleo, @mmusich, @gpetruc, @VinInn this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-565540/39865/summary.html
COMMIT: d6c0d85
CMSSW: CMSSW_14_1_X_2024-06-12-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45213/39865/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3451538
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3451515
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 206 log files, 170 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1
reco comparisons show no changes, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

urgent
Needed for data taking

[antoniovilela]

+1