Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise the EcalElectronicsMappingHost with null detids [14.0.x] #45210

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 12, 2024

PR description:

Initialise the EcalElectronicsMappingHost with null detids explicitly, instead of relying on uninitialised memory.

PR validation:

Fixes #44956.
Running the HLT with export MALLOC_CONF=junk:true now works.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported of #45209 to 14.0.x for data taking.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

type bugfix

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

backport #45209

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

type ecal

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Jun 12, 2024
@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

enable gpu

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/EcalRawToDigi (reconstruction)

@jfernan2, @cmsbuild, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @missirol, @wang0jin, @thomreis, @argiro, @rchatter, @Martin-Grunewald this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 12, 2024

cms-bot internal usage

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 12, 2024

@thomreis @VinInn FYI

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab4068/39856/summary.html
COMMIT: 3e7d8d4
CMSSW: CMSSW_14_0_X_2024-06-12-1600/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45210/39856/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 82 lines to the logs
  • Reco comparison results: 48 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3339338
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3339312
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 35 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 39740
  • DQMHistoTests: Total failures: 1056
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 38684
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 10 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants